Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: Compute kind of widget #30267

Merged
merged 10 commits into from
Dec 16, 2021

Conversation

howard-e
Copy link
Contributor

References whatwg/html#7004

@zcorpan
Copy link
Member

zcorpan commented Sep 10, 2021

infrastructure/ tests ought to be unrelated to this PR

@zcorpan
Copy link
Member

zcorpan commented Sep 13, 2021

@andruud can you review?

@josepharhar
Copy link
Contributor

Is merging this blocked on the csswg and whatwg/html spec PRs?

Also, would it make sense to make the filenames have "appearance" in their filename? I think it would make them easier to find and query for when looking for appearance related WPTs, since it looks like there is no dedicated directory for appearance tests in the css-ui directory.

@zcorpan
Copy link
Member

zcorpan commented Nov 19, 2021

Is merging this blocked on the csswg and whatwg/html spec PRs?

I think it would be nice to merge all 3 at the same time when they're all reviewed.

Also, would it make sense to make the filenames have "appearance" in their filename? I think it would make them easier to find and query for when looking for appearance related WPTs, since it looks like there is no dedicated directory for appearance tests in the css-ui directory.

Certainly. Will fix.

@zcorpan
Copy link
Member

zcorpan commented Nov 19, 2021

update-built check failed, that needs to be fixed. (Edit: done.)

@zcorpan
Copy link
Member

zcorpan commented Nov 19, 2021

wpt-chrome-dev-results check now fails with "The GPU process has crashed 6 time(s)" :/

https://community-tc.services.mozilla.com/tasks/HUL4rwR0SDWs2qrsYxXGLA/runs/0/logs/public/logs/live.log#L1027

@foolip any idea?

@josepharhar
Copy link
Contributor

I have filed a webkit bug to implement these changes: https://bugs.webkit.org/show_bug.cgi?id=233430

@zcorpan
Copy link
Member

zcorpan commented Nov 22, 2021

I tried rebasing on the latest master to see if the error in CI would go away, but it did not. I don't know what's up...

The GPU process has crashed 6 time(s)

https://community-tc.services.mozilla.com/tasks/SfckzfzUSwmykRfqhTZGmA/runs/0/logs/public/logs/live.log

@web-platform-tests/admins can you help?

@foolip
Copy link
Member

foolip commented Nov 23, 2021

@zcorpan I've worked around the issue with #31715 now. Rebasing this should fix the problem.

But there's really no need, since only the Chrome jobs were failing, I'd just admin merge this, rather than waiting for CI to run again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants