fix validateStreamFromPartialString test utility #29517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into this as FormData is now emitted in multiple chunks in Deno. ArrayBuffer doesn't have a `.set` method, Uint8Array does. Seems no-one has ran into this previously as data is always emitted in a single chunk in all browsers for the test cases that use this.
wpt-pr-bot
requested review from
annevk,
domfarolino,
jdm,
mnot,
youennf and
yutakahirano
10 tasks
|
sink-task failed because wpt-chrome-dev-stability failed. The flakes are not new, so unreleated to this PR. |
foolip
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this as FormData is now emitted in multiple chunks in Deno.
ArrayBuffer doesn't have a
.setmethod, Uint8Array does. Seems no-onehas ran into this previously as data is always emitted in a single chunk
in all browsers for the test cases that use this.