Commits on Nov 19, 2021

1. Change behavior of window.open w.r.t. windowPreferences and popups …

   See [1] and [2] for more context, but this CL implements new behavior
   for how window.open() interprets the windowPreferences argument when
   deciding whether to open the window as a new tab or as a "popup",
   which is a separate window with minimal UI (toolbars, onmibox,
   etc.), and also what to return from the BarProp visible properties,
   e.g. window.toolbar.visible.
   
   The existing "trigger" behavior for popups will be retained by this
   CL, namely that a popup will be opened instead of a tab if:
    1. the windowFeatures parameter is *not* empty, and
    2. one of the following conditions is true:
     * both `location` and `toolbar` are false or missing
     * `menubar` is false or missing
     * `resizable is false or missing
     * `scrollbar` is false or missing
     * `status` is false or missing
   
   With this CL, an additional windowFeature called 'popup' is added,
   so that if 'popup' is present and truthy.
   
   Additionally, all BarProp properties (locationbar,menubar,
   personalbar,scrollbars,statusbar, and toolbar) will always return
   the same values, either false if a popup was opened, or true if
   a tab/window was opened.
   
   The spec for this behavior is part of the HTML spec:
   https://html.spec.whatwg.org/multipage/window-object.html#popup-window-is-requested
   
   The intent to ship is here:
   https://groups.google.com/a/chromium.org/g/blink-dev/c/q6ybnmxxvpE
   
   [1] whatwg/html#5872
   [2] whatwg/html#6530
   
   Fixed: 1192701
   Change-Id: I50e745b1000d460c49085edd57d13f420b875ff3
   Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2950386
   Reviewed-by: Joey Arhar <[email protected]>
   Commit-Queue: Mason Freed <[email protected]>
   Cr-Commit-Position: refs/heads/main@{#943716}

   

   mfreed7 authored and chromium-wpt-export-bot committed Nov 19, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for b9ebb8a
   • Browse repository at this point

   Copy the full SHA

   b9ebb8a View commit details

   Browse the repository at this point in the history