Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=223758 #29027

Conversation

shvaikalesh
Copy link
Member

This upstream reviewed change tests global object's operations, getters, and setters called with this value of undefined and null (same-realm for now). See whatwg/webidl#155.

Also, tests AudioWorkletGlobalScope::registerProcessor() called on globalThis, which was reported to be required for audio worklets.

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the WebKit project.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not reviewing the web audio stuff because their custom testharness is too confusing.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-WebAudio stuff LGTM

Copy link

@rtoy rtoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the WebAudio parts.

You don't have to use the audit infrastructure if you don't want to, but it looks fine as is.

@shvaikalesh shvaikalesh merged commit d4e0947 into web-platform-tests:master May 20, 2021
@shvaikalesh shvaikalesh deleted the global-object-implicit-this-value branch May 20, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants