-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=223758 #29027
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=223758 #29027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the WebKit project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not reviewing the web audio stuff because their custom testharness is too confusing.
WebIDL/ecmascript-binding/global-object-implicit-this-value.any.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-WebAudio stuff LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the WebAudio parts.
You don't have to use the audit infrastructure if you don't want to, but it looks fine as is.
This upstream reviewed change tests global object's operations, getters, and setters called with
this
value ofundefined
andnull
(same-realm for now). See whatwg/webidl#155.Also, tests
AudioWorkletGlobalScope::registerProcessor()
called onglobalThis
, which was reported to be required for audio worklets.