Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[url] Forbid | in URL hosts #28118

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

achristensen07
Copy link
Contributor

These tests go with URL issue #559

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against jsdom/whatwg-url and works. The asdf://%43|/ case caught a bug in my first pass where I updated our containsForbiddenHostCodePoint function but didn't update our containsForbiddenHostCodePointExcludingPercent function.

@achristensen07
Copy link
Contributor Author

This goes with whatwg/url#559

annevk pushed a commit to whatwg/url that referenced this pull request Mar 22, 2021
@annevk annevk mentioned this pull request Mar 22, 2021
3 tasks
@annevk annevk merged commit 5eebfdb into web-platform-tests:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants