[Gecko Bug 1668133] Check consistency of getTargetRanges() at calling various timing in an independent WPT
#25942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an independent WPT Currently, it's tested in `input-events-get-target-ranges-*.tentative.html` after checking the target ranges, however, Blink always fails this check. That makes it harder to check which test actually failed on Chrome. Therefore, this patch makes the existing tests stop check it, and creates new WPT to check only it. Note that due to some prettier's rlues have been changed so that VSCode reformatted the JS file. Differential Revision: https://phabricator.services.mozilla.com/D91891 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1668133 gecko-commit: bd5d3910d2a4a819208b4e6f767c2d42a8a8d74d gecko-reviewers: smaug
wpt-pr-bot
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's tested in
input-events-get-target-ranges-*.tentative.htmlafter checking the target ranges, however, Blink always fails this check.
That makes it harder to check which test actually failed on Chrome.
Therefore, this patch makes the existing tests stop check it, and creates
new WPT to check only it.
Note that due to some prettier's rlues have been changed so that VSCode
reformatted the JS file.
Differential Revision: https://phabricator.services.mozilla.com/D91891
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1668133
gecko-commit: bd5d3910d2a4a819208b4e6f767c2d42a8a8d74d
gecko-reviewers: smaug