Add reftests for transform animations #25937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 1, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2443209
branch
4 times, most recently
from
192529c to
2a1b2c9
Compare
Because composited animations are inaccessible from js, reftests are necessary to test their behavior. In this set, the file transform-interpolation-reftests.js defines the tests themselves and several wrapper html files each run a subset of them (this structure is due to the lack of support for test variants in reftests). As these tests are specifically meant for testing compositor animations, add css-transforms to the virtual/threaded suite to test with threaded compositing. As this has found several errors, bugs have been filed and linked to the threaded cases in TestExpectations Bug: 1131196, 1133901, 1131252 Change-Id: I9c6d92727e52a3ec11fe56f3375fc352baeadf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443209 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: George Steel <[email protected]> Cr-Commit-Position: refs/heads/master@{#813921}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2443209
branch
from
2a1b2c9 to
205f040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because composited animations are inaccessible from js, reftests are
necessary to test their behavior. In this set, the file
transform-interpolation-reftests.js defines the tests themselves and
several wrapper html files each run a subset of them (this structure
is due to the lack of support for test variants in reftests).
As these tests are specifically meant for testing compositor animations,
add css-transforms to the virtual/threaded suite to test with threaded
compositing. As this has found several errors, bugs have been filed and
linked to the threaded cases in TestExpectations
Bug: 1131196, 1133901, 1131252
Change-Id: I9c6d92727e52a3ec11fe56f3375fc352baeadf04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443209
Reviewed-by: Kevin Ellis <[email protected]>
Commit-Queue: George Steel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#813921}