[PTZ] Deny mandatory PTZ constraints in basic getUserMedia constraints #25785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 25, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2411946
branch
5 times, most recently
from
a08342b to
0b383a5
Compare
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Eero Häkkinen <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#811242}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2411946
branch
from
0b383a5 to
a5c6ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.
Spec:
w3c/mediacapture-image#261
w3c/mediacapture-main#707
Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Eero Häkkinen <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#811242}