Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[webdriver] Close old windows at the end of each test as well… #25544

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Revert "[webdriver] Close old windows at the end of each test as well… #25544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions tools/wptrunner/wptrunner/executors/executorwebdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,10 +409,7 @@ def do_test(self, test):
def do_testharness(self, protocol, url, timeout):
format_map = {"url": strip_server(url)}

# In theory the previous test should have closed any leftover windows,
# but to avoid relying on that we also attempt cleanup here.
parent_window = protocol.testharness.close_old_windows()

# Now start the test harness
protocol.base.execute_script("window.open('about:blank', '%s', 'noopener')" % self.window_id)
test_window = protocol.testharness.get_test_window(self.window_id,
Expand Down Expand Up @@ -449,11 +446,6 @@ def do_testharness(self, protocol, url, timeout):
done, rv = handler(result)
if done:
break

# Attempt to cleanup any leftover windows. This should create a clean
# state for future tests, and expose any unexpectedly-open prompts.
protocol.testharness.close_old_windows()

return rv

def wait_for_load(self, protocol):
Expand Down