Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variable to avoid mypy type error #23669

Merged
merged 4 commits into from
May 19, 2020
Merged

Rename variable to avoid mypy type error #23669

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc7f07b
Testing MYPY complaints for sourcefile.py
stephenmcgruer May 18, 2020
9ff4273
Add another loc
stephenmcgruer May 18, 2020
3fe799c
Fix mypy
stephenmcgruer May 18, 2020
4b2c645
Rename variable instead
stephenmcgruer May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/manifest/sourcefile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,9 +992,9 @@ def manifest_items(self):

if drop_cached and "__cached_properties__" in self.__dict__:
cached_properties = self.__dict__["__cached_properties__"]
for key in cached_properties:
if str(key) in self.__dict__:
del self.__dict__[str(key)]
for prop in cached_properties:
if prop in self.__dict__:
del self.__dict__[prop]
del self.__dict__["__cached_properties__"]

return rv