Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wake lock: Remove WakeLockPermissionDescriptor, use separate permission names. #22658

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 2, 2020

This adapts the implementation to some of the breaking spec changes
introduced in w3c/screen-wake-lock#255.

Namely, WakeLockPermissionDescriptor has been removed in favor of using a
regular PermissionDescriptor object with |name| set to "screen-wake-lock".

That spec change also removed system wake locks (and consequently the
additions to the WorkerNavigator interface) altogether, but that will be
done in a separate CL, so for now we also support a PermissionDescriptor
object with |name| set to "system-wake-lock".

Bug: 257511, 1064685
Change-Id: I096f3fae24444da5ca6b1eeb3889a813a9e5f270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134228
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Auto-Submit: Raphael Kubo da Costa <[email protected]>
Commit-Queue: Raphael Kubo da Costa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#756753}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

…on names.

This adapts the implementation to some of the breaking spec changes
introduced in w3c/screen-wake-lock#255.

Namely, WakeLockPermissionDescriptor has been removed in favor of using a
regular PermissionDescriptor object with |name| set to "screen-wake-lock".

That spec change also removed system wake locks (and consequently the
additions to the WorkerNavigator interface) altogether, but that will be
done in a separate CL, so for now we also support a PermissionDescriptor
object with |name| set to "system-wake-lock".

Bug: 257511, 1064685
Change-Id: I096f3fae24444da5ca6b1eeb3889a813a9e5f270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134228
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Auto-Submit: Raphael Kubo da Costa <[email protected]>
Commit-Queue: Raphael Kubo da Costa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#756753}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7ab34f7 into master Apr 6, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2134228 branch April 6, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants