Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: use Wasm to get a SharedArrayBuffer instance #22385

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 23, 2020

And verify that the SharedArrayBuffer constructor isn't exposed without COOP+COEP.

For #22358.

And verify that the SharedArrayBuffer constructor isn't exposed without COOP+COEP.

For #22358.
// See https://github.com/whatwg/html/issues/5380 for why not `new SharedArrayBuffer()`
assert_equals(globalThis.SharedArrayBuffer, undefined);
assert_false("SharedArrayBuffer" in globalThis);
}, "SharedArrayBuffer constructor does not exist without COOP+COEP");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syg @domenic any other angles to test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah that should do it.

Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAB changes themselves lgtm, with caveat I don't really know how WPTs work.

@annevk annevk merged commit 288c95a into master Mar 24, 2020
@annevk annevk deleted the annevk/sab-to-wasm-switch-remainder branch March 24, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants