Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHR/CSS/Compression: use Wasm to get at a SharedArrayBuffer instancd #22359

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 20, 2020

For #22358.

@ricea
Copy link
Contributor

ricea commented Mar 23, 2020

So, IIUC, there are going to be cases where the SharedArrayBuffer constructor is not exposed, but you can still construct one? If so, compression and decompression lgtm.

@annevk
Copy link
Member Author

annevk commented Mar 23, 2020

Yeah, exactly that.

Copy link
Contributor

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I can also lgtm xhr. The css stuff looks okay, but I'm not involved in css.

@annevk annevk merged commit c8d8f8e into master Mar 24, 2020
@annevk annevk deleted the annevk/wasm-sab-xhr-css-compression branch March 24, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants