Convert slant angle from CSS to OpenType for web font instantiation #22357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 20, 2020
OpenType and CSS use opposite directions for the slant angle of a variable font, compare note in [1] and test case in [2]. After the issue was resolved in the CSS spec to keep these opposite directions, convert from CSS to OpenType before shaping. [1] https://drafts.csswg.org/css-fonts/#font-style-prop [2] https://arrowtype.github.io/vf-slnt-test/ Bug: 859869 Change-Id: Ib1cc9224edab1dc17d8c6ed200e8369714cc73ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109762 Commit-Queue: Koji Ishii <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/master@{#752096}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2109762
branch
from
c5e0386 to
608b8dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenType and CSS use opposite directions for the slant angle of a
variable font, compare note in [1] and test case in [2]. After the issue
was resolved in the CSS spec to keep these opposite directions, convert
from CSS to OpenType before shaping.
[1] https://drafts.csswg.org/css-fonts/#font-style-prop
[2] https://arrowtype.github.io/vf-slnt-test/
Bug: 859869
Change-Id: Ib1cc9224edab1dc17d8c6ed200e8369714cc73ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109762
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#752096}