Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WPTs for parse error handling in SharedWorkers #22185

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions workers/modules/shared-worker-parse-error-failure.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<!DOCTYPE html>
<title>SharedWorker: parse error failure</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../support/check-error-arguments.js"></script>
<script>

// Check if module shared worker is supported.
// In this test scope, we only use simple non-nested static import as a feature
// of module shared worker, so we only check if static import is supported.
//
// This check is necessary to appropriately test parse error handling because
// we need to distingusih the parse error invoked by unsupported "import" in
// the top-level script from the parse error invoked by the statically imported
// script which is the one we want to check in this test.
promise_setup(async () => {
const scriptURL = 'resources/static-import-worker.js';
const worker = new SharedWorker(scriptURL, { type: 'module' });
const supportsModuleWorkers = await new Promise((resolve, reject) => {
worker.port.onmessage = e => {
resolve(e.data.length == 1 && e.data[0] == 'export-on-load-script.js');
};
worker.onerror = () => reject(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
worker.onerror = () => reject(false);
worker.onerror = () => resolve(false);

});
assert_precondition(
supportsModuleWorkers,
"Static import must be supported on module shared worker to run this test."
);
});

promise_test(async () => {
const scriptURL = 'resources/syntax-error.js';
const worker = new SharedWorker(scriptURL, { type: 'module' });
const args = await new Promise(resolve =>
worker.onerror = (...args) => resolve(args));
window.checkErrorArguments(args);
}, 'Module shared worker construction for script with syntax error should ' +
'dispatch an event named error.');

promise_test(async () => {
const scriptURL = 'resources/static-import-syntax-error.js';
const worker = new SharedWorker(scriptURL, { type: 'module' });
const args = await new Promise(resolve =>
worker.onerror = (...args) => resolve(args));
window.checkErrorArguments(args);
}, 'Static import on module shared worker for script with syntax error ' +
'should dispatch an event named error.');

</script>
26 changes: 26 additions & 0 deletions workers/shared-worker-parse-error-failure.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<!DOCTYPE html>
<title>SharedWorker: parse error failure</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="./support/check-error-arguments.js"></script>
<script>

promise_test(async () => {
domenic marked this conversation as resolved.
Show resolved Hide resolved
const scriptURL = 'modules/resources/syntax-error.js';
const worker = new SharedWorker(scriptURL, { type: 'classic' });
const args = await new Promise(resolve =>
worker.onerror = (...args) => resolve(args));
window.checkErrorArguments(args);
}, 'Classic shared worker construction for script with syntax error should ' +
'dispatch an event named error.');

promise_test(async () => {
const scriptURL = 'modules/resources/static-import-worker.js';
const worker = new SharedWorker(scriptURL, { type: 'classic' });
const args = await new Promise(resolve =>
worker.onerror = (...args) => resolve(args));
window.checkErrorArguments(args);
}, 'Static import on classic shared worker should dispatch an event named ' +
'error.');

</script>
4 changes: 4 additions & 0 deletions workers/support/check-error-arguments.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
window.checkErrorArguments = args => {
assert_equals(args.length, 1);
assert_equals(args[0].constructor, Event);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
};