Fix timeout in update-and-send-events-replacment.html #22160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 10, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2096782
branch
2 times, most recently
from
3886d45
to
0318643
Compare
The handling of iframe load events is finicky as indicated in the open WHATWG issue: whatwg/html#490 This patch switches the wait mechanism to one that is well behaved across browsers. The new process arms the listener before inserting the iframe into the document. Bug: 1059963 Change-Id: I372d4fdae3b270699aedf2c5a4de4429e62f42a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096782 Reviewed-by: Yi Gu <[email protected]> Commit-Queue: Kevin Ellis <[email protected]> Cr-Commit-Position: refs/heads/master@{#748853}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2096782
branch
from
0318643
to
ecc8ad0
Compare
|
Changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of iframe load events is finicky as indicated in the open
WHATWG issue:
whatwg/html#490
This patch switches the wait mechanism to one that is well behaved
across browsers. The new process arms the listener before inserting the
iframe into the document.
Bug: 1059963
Change-Id: I372d4fdae3b270699aedf2c5a4de4429e62f42a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096782
Reviewed-by: Yi Gu <[email protected]>
Commit-Queue: Kevin Ellis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#748853}