Split html/.../query-encoding/ tests #21881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 19, 2020
|
wpt-firefox-nightly-stability is failing like this: Unstable results
That ought to be a pre-existing problem, so I'll admin merge this when https://chromium-review.googlesource.com/2063808 has landed. |
These tests cover 5 encodings (UTF-8, UTF-16LE/BE, Windows-1251/1252) and exercise many features (HTML, CSS, SVG, Workers, ...). They're currently all skipped in Chrome (and other browser CI systems), since something in that huge matrix fails or times out for everyone. #4934 suggests splitting these into separate files. As a stopgap, split them out using the WPT "variant" mechanism and provide expected failure files for subsets, which should make fixing the tests and/or browsers more actionable, and let us catch new regressions. Bug: 930297 Change-Id: I4813281f547216b2b5f377118a58a419f62cfbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063808 Commit-Queue: Philip Jägenstedt <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Cr-Commit-Position: refs/heads/master@{#743019}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2063808
branch
from
5d81dbd to
ef23140
Compare
|
Chrome CL is in (thanks!) - @foolip can you admin merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests cover 5 encodings (UTF-8, UTF-16LE/BE, Windows-1251/1252)
and exercise many features (HTML, CSS, SVG, Workers, ...). They're
currently all skipped in Chrome (and other browser CI systems), since
something in that huge matrix fails or times out for everyone.
#4934 suggests
splitting these into separate files. As a stopgap, split them out
using the WPT "variant" mechanism and provide expected failure files
for subsets, which should make fixing the tests and/or browsers more
actionable, and let us catch new regressions.
Bug: 930297
Change-Id: I4813281f547216b2b5f377118a58a419f62cfbc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063808
Commit-Queue: Philip Jägenstedt <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#743019}