MediaRecorder: Implements spontaneous stopping. #20865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 19, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1969577
branch
3 times, most recently
from
3f60003
to
191c3a5
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1969577
branch
5 times, most recently
from
2a17f90
to
ace591e
Compare
When all recorded tracks have ended, the MediaRecorder should spontaneously stop and invoke onstop(), according to https://www.w3.org/TR/mediastream-recording/#mediarecorder-methods. This change implements this previously unimplemented feature. Bug: 1013590,1035454 Change-Id: Ia96fa56f8ef20ff347822591c01703bfb276072b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969577 Commit-Queue: Markus Handell <[email protected]> Reviewed-by: Miguel Casas <[email protected]> Reviewed-by: Guido Urdaneta <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Cr-Commit-Position: refs/heads/master@{#729067}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1969577
branch
from
ace591e
to
4c872c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all recorded tracks have ended, the MediaRecorder should spontaneously
stop and invoke onstop(), according to
https://www.w3.org/TR/mediastream-recording/#mediarecorder-methods.
This change implements this previously unimplemented feature.
Bug: 1013590,1035454
Change-Id: Ia96fa56f8ef20ff347822591c01703bfb276072b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969577
Commit-Queue: Markus Handell <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#729067}