Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COEP: test that <meta http-equiv> is not supported #20842

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Dec 18, 2019

No description provided.

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good, and https://wpt.fyi/results/html/cross-origin-embedder-policy/meta-http-equiv.https.html?sha=f174353edd&label=pr_head shows all browser passing, which makes sense for a negative test.

@foolip foolip merged commit bbc8aee into master Dec 18, 2019
@foolip foolip deleted the zcorpan/coep-no-http-equiv branch December 18, 2019 16:58
@zcorpan
Copy link
Member Author

zcorpan commented Dec 19, 2019

Thanks, @foolip.

I also verified that the test does what I expect by adding a .headers file that sets the COEP header and running with wpt serve in Chrome Canary with "Cross Origin Isolation" pref enabled, which failed the test. (I believe it's not possible to set arbitrary prefs for wpt run, so I was lucky that COEP didn't require a secure context to do its thing!)

@zcorpan
Copy link
Member Author

zcorpan commented Dec 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants