Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-flexbox] Don't cache definiteness when there's an override container height #20137

Merged
merged 1 commit into from
Nov 7, 2019
+37 −0
Merged

[css-flexbox] Don't cache definiteness when there's an override container height #20137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions css/css-flexbox/percentage-heights-009.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<!DOCTYPE html>
<title>height: 100% should not be considered indefinite on a second flex item (triggers an obscure bug in Blink)</title>
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#definite-sizes" />
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1019138" />
<link rel="match" href="../reference/ref-filled-green-100px-square.xht" />
<style type="text/css">
.container {
height: 100px;
width: 100px;
}
.flexbox {
background: red;
display: flex;
flex-direction: column;
height: 100%;
}
.first-item {
background: green;
display: flex;
}
.second-item {
/* This should not be considered indefinite */
height: 100%;
background: green;
}
</style>

<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div class="container">
<div class="flexbox">
<div class="first-item">
<div style="width: 100px; height: 20px;"></div>
</div>
<div class="second-item">
</div>
</div>
</div>