Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-masking] Parsing mask-position #17623

Merged
merged 1 commit into from
Jul 4, 2019
Merged

[css-masking] Parsing mask-position #17623

merged 1 commit into from
Jul 4, 2019

Conversation

ewilligers
Copy link
Contributor

mask-position accepts <position>#
https://drafts.fxtf.org/css-masking-1/#the-mask-position

3-valued positions are not accepted
w3c/csswg-drafts#2140

@ewilligers ewilligers requested a review from emilio July 3, 2019 13:12
@BorisChiou
Copy link
Member

Thanks for adding these. :)

@emilio
Copy link
Contributor

emilio commented Jul 4, 2019

@BorisChiou any chance you can review these? I'm away-ish this week.

BorisChiou
BorisChiou approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@BorisChiou BorisChiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. :)

@ewilligers ewilligers merged commit 2831268 into web-platform-tests:master Jul 4, 2019
@ewilligers ewilligers deleted the mask-position branch July 4, 2019 23:41
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
@ewilligers @natechapin
[css-masking] Parsing mask-position (web-platform-tests#17623)
4bb9a8d 
mask-position accepts <position>#
https://drafts.fxtf.org/css-masking-1/#the-mask-position

3-valued positions are not accepted
w3c/csswg-drafts#2140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BorisChiou BorisChiou BorisChiou approved these changes

@emilio emilio Awaiting requested review from emilio

@birtles birtles Awaiting requested review from birtles

@dirkschulze dirkschulze Awaiting requested review from dirkschulze

@tabatkins tabatkins Awaiting requested review from tabatkins

Assignees

@birtles birtles

Labels
css-masking wg-css wg-svg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ewilligers @BorisChiou @emilio @birtles @wpt-pr-bot @ericwilligers