COOP and COEP tests #17606

annevk · 2019-07-02T14:54:28Z

Initial (incomplete) take at restructuring some of the existing tests to account for name and logic changes.

TODO:

Rewrite COEP popup tests (at the end of require-corp.tentative.html) into COOP+COEP tests.
Add more COOP+COEP tests.
Add COOP unsafe-inherit tests. (Writing this down I realize currently it also inherits COEP which is a bug. Make sure to test that and fix the draft.)
Add some tests for initial/non-initial about:blank/blob/data URLs.
Workers...
[Suggestions?]

csreis · 2019-07-03T00:03:28Z

Thanks for adding these tests! I hadn't seen the existing WPT tests for COOP and Cross-Origin, so I'll try to take a closer look at them. Your proposed changes here seem reasonable to me.

One question I was wondering about when working on the Chrome implementation, and which might be useful to cover in a test-- when a frame is navigating, is the COOP comparison made against the current document in the frame or the initiator of the navigation? For example: page A1 (with a policy and unsafe-allow-origin) opens page B (no header), staying in the group.

If A1 then tells B's frame to navigate to A2 (with a matching policy to A1), is that considered a match with A1 and stays in the group? Or is it compared against B and considered a mismatch?
If instead, B navigates itself to A2, is that considered a policy mismatch forcing a new group? Or did B inherit A1's policy and it's considered a match?

annevk · 2019-07-03T15:21:44Z

As currently written currentCOOP would always be from B and there's no inheritance, so a mismatch in both cases. The only time the initiator comes into play (and you could talk about inheritance of sorts) is with initial about:blank. (And yeah, we should test this!)

mystor · 2019-07-03T15:58:57Z

html/cross-origin-embedder-policy/require-corp.https.html

html/cross-origin-embedder-policy/none.https.html

html/cross-origin-embedder-policy/resources/nothing.txt.headers

- "cross-origin-embedder-policy" set's the policy for frame. - dedicated worker's policy is set to the ancestor frame's policy. - nested frames with a conflicting policy is blocked. SharedWorker / ServiceWorker are not yet supported. All the implementation is behind the flag, and tested manually with work in progress WPTs[1]. 1: web-platform-tests/wpt#17606 Bug: 887967 Change-Id: I70ed24841afde1b3c72dad40288744bb92a6f5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715378 Commit-Queue: Yutaka Hirano <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Cr-Commit-Position: refs/heads/master@{#682609}

hsivonen · 2019-08-05T07:03:26Z

re-navigation due to <meta charset> I'd like to outlaw if possible.

I'd be OK with adding a flag to Gecko's HTML parser to prevent renavigation on late <meta charset> when certain headers are set if WebKit and Blink make their meta prescanner strictly obey the 1024-byte limit when those headers are set.

html/cross-origin-embedder-policy/require-corp.https.html

html/cross-origin-embedder-policy/sandbox.https.html

html/cross-origin-embedder-policy/require-corp.https.html

annevk · 2019-08-09T14:20:14Z

This is ready for another round of feedback. #18354 lists the remaining work. Please add suggestions for further tests there.

yutakahirano · 2019-08-12T14:09:32Z

LGTM (I only looked at the COEP part).

JuniorHsu

Mostly from the point of readability.

JuniorHsu · 2019-08-13T06:25:54Z

html/cross-origin-opener-policy/resources/common.js

+  coop_coep_test(t, host, coop, "", channelName, hasOpener);
+}
+
+function run_coop_tests(mainTest, testArray) {


annotate or use variable name to indicate mainTest is a COOP value.

JuniorHsu · 2019-08-13T06:29:19Z

html/cross-origin-opener-policy/resources/common.js

+}
+
+function coop_coep_test(t, host, coop, coep, channelName, hasOpener) {
+  url_test(t, `${host.origin}/html/cross-origin-opener-policy/resources/coop-coep.py?coop=${encodeURIComponent(coop)}&coep=${coep}&channel=${channelName}`, channelName, hasOpener);


This is too long. One solution might be
let url = ${host.origin}/html/cross-origin-opener-policy/resources/coop-coep.py;
url += `?coop=...

JuniorHsu · 2019-08-13T06:31:52Z

html/cross-origin-opener-policy/resources/common.js

+const SAME_SITE = {origin: get_host_info().HTTPS_REMOTE_ORIGIN, name: "SAME_SITE"};
+const CROSS_ORIGIN = {origin: get_host_info().HTTPS_NOTSAMESITE_ORIGIN, name: "CROSS_ORIGIN"}
+
+function url_test(t, url, channelName, hasOpener) {


The name url_test is kinda misleading. Actually we're test hasOpener

JuniorHsu · 2019-08-13T06:40:03Z

html/cross-origin-opener-policy/coep-navigate-popup.https.html

+    const navigateHost = site === "same-origin" ? SAME_ORIGIN : SAME_SITE;
+    const navigateURL = `${navigateHost.origin}/html/cross-origin-opener-policy/resources/coop-coep.py?coop=${variant.coop}&coep=${variant.coep}&channel=${channel}`;
+    const opener = site === "same-origin" ? variant.opener : false;
+


IMO it's a complicated test. Could you put some comments about the testing flow?

JuniorHsu · 2019-08-13T06:41:28Z

html/cross-origin-opener-policy/no-https.html

+    popup.close();
+    t.done();
+  }, 500);
+}, "Cross-Origin-Opener-Policy only works over HTTPS");


s/HTTPS/secure contexts

annevk · 2019-08-13T15:22:55Z

Proposed commit message:

COOP and COEP tests

See the added html/cross-origin-opener-policy/README.md for details.

Ms2ger · 2019-08-13T15:27:02Z

ERROR:lint:html/cross-origin-embedder-policy/resources/navigate-none.sub.html:9: setTimeout used; step_timeout should typically be used instead (SET TIMEOUT)
ERROR:lint:html/cross-origin-embedder-policy/resources/navigate-require-corp.sub.html:15: setTimeout used; step_timeout should typically be used instead (SET TIMEOUT)

COOP and COEP tests

98d6244

wpt-pr-bot added the html label Jul 2, 2019

wpt-pr-bot assigned zqzhang Jul 2, 2019

wpt-pr-bot requested review from domenic, foolip, jdm, jgraham, zcorpan and zqzhang July 2, 2019 14:54

annevk unassigned zqzhang Jul 2, 2019

annevk requested review from mikewest and removed request for jdm, zcorpan, jgraham, foolip, domenic and zqzhang July 2, 2019 15:00

This comment has been minimized.

Sign in to view

wpt-pr-bot added the status:needs-reviewers label Jul 3, 2019

annevk added 7 commits July 5, 2019 11:41

COOP nits

27ce307

COEP cleanup

5cd9310

Restructure COOP some more, add couple COOP+COEP tests

4cf35a4

COOP nits

4a3d684

COOP/COEP + navigate the popup

d757e93

Redirect tests

4494a41

add READMEs

21de39b

annevk mentioned this pull request Jul 8, 2019

Making postMessage() work for SharedArrayBuffer (Cross-Origin-Embedder-Policy) whatwg/html#4175

Closed

JuniorHsu reviewed Jul 20, 2019

View reviewed changes

html/cross-origin-embedder-policy/require-corp.https.html Show resolved Hide resolved

JuniorHsu reviewed Jul 23, 2019

View reviewed changes

html/cross-origin-embedder-policy/require-corp.https.html Show resolved Hide resolved

JuniorHsu reviewed Jul 24, 2019

View reviewed changes

html/cross-origin-embedder-policy/require-corp.https.html Show resolved Hide resolved

JuniorHsu reviewed Jul 24, 2019

View reviewed changes

html/cross-origin-embedder-policy/none.https.html Outdated Show resolved Hide resolved

JuniorHsu reviewed Jul 24, 2019

View reviewed changes

html/cross-origin-embedder-policy/resources/nothing.txt.headers Outdated Show resolved Hide resolved

yutakahirano requested changes Aug 5, 2019

View reviewed changes

html/cross-origin-embedder-policy/require-corp.https.html Outdated Show resolved Hide resolved

address review comments

f2fec47

yutakahirano approved these changes Aug 7, 2019

View reviewed changes

html/cross-origin-embedder-policy/sandbox.https.html Outdated Show resolved Hide resolved

yutakahirano requested changes Aug 7, 2019

View reviewed changes

html/cross-origin-embedder-policy/require-corp.https.html Outdated Show resolved Hide resolved

yutakahirano reviewed Aug 7, 2019

View reviewed changes

html/cross-origin-embedder-policy/require-corp.https.html Show resolved Hide resolved

yutakahirano reviewed Aug 7, 2019

View reviewed changes

html/cross-origin-embedder-policy/require-corp.https.html Show resolved Hide resolved

yutakahirano reviewed Aug 7, 2019

View reviewed changes

html/cross-origin-embedder-policy/require-corp.https.html Show resolved Hide resolved

feedback

60bff62

annevk mentioned this pull request Aug 9, 2019

Remaining COOP and COEP testing work #18354

Open

16 tasks

yutakahirano approved these changes Aug 12, 2019

View reviewed changes

JuniorHsu approved these changes Aug 13, 2019

View reviewed changes

address the nits I'm comfortable making without fearing mistakes

6ea08e9

intentional usage of setTimeout

bc23837

wpt-pr-bot added the infra label Aug 13, 2019

wpt-pr-bot requested a review from jgraham August 13, 2019 15:30

annevk merged commit 5690096 into master Aug 14, 2019

annevk deleted the annevk/coop-and-coep branch August 14, 2019 11:41

annevk restored the annevk/coop-and-coep branch August 16, 2019 12:37

annevk deleted the annevk/coop-and-coep branch August 16, 2019 12:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

COOP and COEP tests #17606

COOP and COEP tests #17606

annevk commented Jul 2, 2019 •

edited

Loading

csreis commented Jul 3, 2019

This comment has been minimized.

annevk commented Jul 3, 2019 •

edited

Loading

mystor commented Jul 3, 2019 •

edited by JuniorHsu

Loading

hsivonen commented Aug 5, 2019 •

edited

Loading

annevk commented Aug 9, 2019

yutakahirano commented Aug 12, 2019

JuniorHsu left a comment

JuniorHsu Aug 13, 2019

JuniorHsu Aug 13, 2019

JuniorHsu Aug 13, 2019

JuniorHsu Aug 13, 2019

JuniorHsu Aug 13, 2019

annevk commented Aug 13, 2019

Ms2ger commented Aug 13, 2019

COOP and COEP tests #17606

COOP and COEP tests #17606

Conversation

annevk commented Jul 2, 2019 • edited Loading

csreis commented Jul 3, 2019

This comment has been minimized.

annevk commented Jul 3, 2019 • edited Loading

mystor commented Jul 3, 2019 • edited by JuniorHsu Loading

hsivonen commented Aug 5, 2019 • edited Loading

annevk commented Aug 9, 2019

yutakahirano commented Aug 12, 2019

JuniorHsu left a comment

Choose a reason for hiding this comment

JuniorHsu Aug 13, 2019

Choose a reason for hiding this comment

JuniorHsu Aug 13, 2019

Choose a reason for hiding this comment

JuniorHsu Aug 13, 2019

Choose a reason for hiding this comment

JuniorHsu Aug 13, 2019

Choose a reason for hiding this comment

JuniorHsu Aug 13, 2019

Choose a reason for hiding this comment

annevk commented Aug 13, 2019

Ms2ger commented Aug 13, 2019

annevk commented Jul 2, 2019 •

edited

Loading

annevk commented Jul 3, 2019 •

edited

Loading

mystor commented Jul 3, 2019 •

edited by JuniorHsu

Loading

hsivonen commented Aug 5, 2019 •

edited

Loading