[css-pseudo] Add some ::first-letter tests #17023
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
frivoal,
gsnedders,
kojiishi and
plinss
r12a
reviewed
May 28, 2019
| <meta charset="utf-8"/> | ||
| <title>CSS3 Pseudo: latin, letter + diacritic</title> | ||
| <meta name="assert" id="assert" content=":first-letter will select a letter + a following combining character at the start of a line."> | ||
| <link rel="help" href="https://drafts.csswg.org/css-pseudo-4/#first-letter-pseudo"> |
There was a problem hiding this comment.
@xfq I believe that ref files are supposed to have no metadata, but i'm pretty sure that they aren't supposed to have help metadata.
There was a problem hiding this comment.
Thanks for the reminder! I just removed them.
There was a problem hiding this comment.
I checked https://web-platform-tests.org/writing-tests/reftests.html#example-reftests and it says that all metadata should be removed. So i think we'll need to also remove the <link rel="author" metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports https://w3c.github.io/i18n-tests/results/first-letter-pseudo to WPT. It includes tests for Latin grapheme clusters, Dutch tailoring, and Devanagari grapheme clusters.
I didn't include the basic functionality test[1] and the exploratory tests.
/cc @r12a
Footnotes:
[1] I believe it's already tested by https://github.com/web-platform-tests/wpt/blob/master/css/css-pseudo/first-letter-001.html