[ElementTiming] Do not expose elements in Shadow Trees #16939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 21, 2019
We initially exposed these elements but this seems to break design invariants. It is still unclear what we can do with elements in shadow trees, but for now it is safest to not expose them at all. Relevant threads: WICG/element-timing#3 WICG/webcomponents#816 Bug: 879270 Change-Id: Id4c0d65e0f0e086c6c6dfa29cc019a4c1ef6ab1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622470 Reviewed-by: Chris Harrelson <[email protected]> Commit-Queue: Nicolás Peña Moreno <[email protected]> Cr-Commit-Position: refs/heads/master@{#662391}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1622470
branch
from
0e36a52
to
d5ebd1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially exposed these elements but this seems to break design
invariants. It is still unclear what we can do with elements in shadow
trees, but for now it is safest to not expose them at all.
Relevant threads:
WICG/element-timing#3
WICG/webcomponents#816
Bug: 879270
Change-Id: Id4c0d65e0f0e086c6c6dfa29cc019a4c1ef6ab1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622470
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Nicolás Peña Moreno <[email protected]>
Cr-Commit-Position: refs/heads/master@{#662391}