[ImageCapture] Add pan/tilt constraint and wire in Linux/CrOS. #15741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 8, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1508519
branch
2 times, most recently
from
253124b to
0cec29d
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1508519
branch
4 times, most recently
from
857a8e4 to
ed1fab2
Compare
5 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1508519
branch
2 times, most recently
from
bcc4621 to
6a38da7
Compare
Pan and Tilt Constraints are part of the UVC spec. For Linux/CrOS, we can use V4L2 controls like (V4L2_CID_PAN_ABSOLUTE and V4L2_CID_TILT_ABSOLUTE). Spec: w3c/mediacapture-image#182 Test Page: https://riju.github.io/WebCamera/samples/panTilt/ Putting Pan/Tilt feature behind a flag: chrome --enable-blink-features=MediaCapturePanTilt Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/d/msg/blink-dev/j-Q08QgBipM/F3a5sau1BwAJ Bug: 934063 Change-Id: I552c4c8be717c3b67c4d91f826a1f16850430fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508519 Reviewed-by: Guido Urdaneta <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Reviewed-by: Miguel Casas <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Commit-Queue: Rijubrata Bhaumik <[email protected]> Cr-Commit-Position: refs/heads/master@{#681332}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1508519
branch
from
6a38da7 to
6455aee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pan and Tilt Constraints are part of the UVC spec.
For Linux/CrOS, we can use V4L2 controls like
(V4L2_CID_PAN_ABSOLUTE and V4L2_CID_TILT_ABSOLUTE).
Spec: w3c/mediacapture-image#182
Test Page: https://riju.github.io/WebCamera/samples/panTilt/
Putting Pan/Tilt feature behind a flag:
chrome --enable-blink-features=MediaCapturePanTilt
Intent to Implement and Ship discussions:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/j-Q08QgBipM/F3a5sau1BwAJ
Bug: 934063
Change-Id: I552c4c8be717c3b67c4d91f826a1f16850430fa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508519
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Rijubrata Bhaumik <[email protected]>
Cr-Commit-Position: refs/heads/master@{#681332}