lazy-load: Increase timeout value to reduce flakes #14536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 14, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1379105
branch
from
ab8ae4d to
8e1ad30
Compare
The test is still a bit flaky after increasing the value to 400ms ( which did in fact reduce flakiness substantially). This CL will increase the value even further (600ms) to further reduce the flakiness. [email protected] Bug: 915236 Change-Id: I1ad650ed14dbf9b054a966324ec033a4bd2f47f8 Reviewed-on: https://chromium-review.googlesource.com/c/1379105 Reviewed-by: Ehsan Karamad <[email protected]> Commit-Queue: Ehsan Karamad <[email protected]> Cr-Commit-Position: refs/heads/master@{#616867}
foolip
force-pushed
the
chromium-export-cl-1379105
branch
from
8e1ad30 to
0cb91a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is still a bit flaky after increasing the value to 400ms (
which did in fact reduce flakiness substantially). This CL will
increase the value even further (600ms) to further reduce the flakiness.
TBR=[email protected]
Bug: 915236
Change-Id: I1ad650ed14dbf9b054a966324ec033a4bd2f47f8
Reviewed-on: https://chromium-review.googlesource.com/c/1379105
Reviewed-by: Ehsan Karamad <[email protected]>
Commit-Queue: Ehsan Karamad <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616867}