-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland "Add quota usage details tests for all other storage backends." #14531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed downstream.
a597604
to
a342a91
Compare
a342a91
to
142e1bc
Compare
This is a reland of 548e7b5e622ad79155ff95ef26738d7a40fe9397 Original change's description: > Add quota usage details tests for all other storage backends. > > IndexedDB test was included in parent CL. > > Bug: 904000 > Test: > Change-Id: Icc3462f13d0dce0197a8ec54f22d5ad794a51292 > Reviewed-on: https://chromium-review.googlesource.com/c/1334659 > Reviewed-by: Victor Costan <[email protected]> > Reviewed-by: Joshua Bell <[email protected]> > Commit-Queue: Jarryd Goodman <[email protected]> > Cr-Commit-Position: refs/heads/master@{#616398} Bug: 904000 Change-Id: I507ec17eabc8e323a7c6418075d4be4787d4c5df Reviewed-on: https://chromium-review.googlesource.com/c/1378805 Reviewed-by: Joshua Bell <[email protected]> Commit-Queue: Jarryd Goodman <[email protected]> Cr-Commit-Position: refs/heads/master@{#617285}
142e1bc
to
cc2ddff
Compare
Taskcluster flakiness in Chrome:
|
@jarryd999 @inexorabletash, see #14531 (comment) for reported flakiness of estimate-usage-details-application-cache.https.tentative.html. Is this expected to happen on Chrome Dev because of some code change that hasn't reached the dev channel yet, or might there be a problem with the test? |
I was able to reproduce the flakiness with the changes in this PR rebased on master (commit 27085bc) running /storage/estimate-usage-details-application-cache.https.tentative.html
Confusingly, the same command on master seems to pass, but that's because the test didn't exist before. |
Like in #15015, seeing consistent 5/10 fail makes me suspect there's no randomness to this, just some test/infra issue. |
Ah, it is a lot like #15015. If the cache is global and the test runs in parallel, then only one of the tests will add to the size of the cache... |
@jarryd999 @inexorabletash @pwnall, this hasn't been merged in wpt yet because of the flakiness, which I think is because the cache is shared. Do you have thoughts on how to fix this issue? A fix like #15018 doesn't seem as straightforward here, I think one would need a unique appcache.manifest for each load? But how does appcache interact, is it even possible to install arbitrary number of appcaches for the same domain/path/something? |
I've run |
Filed #15036. |
This is a reland of 548e7b5e622ad79155ff95ef26738d7a40fe9397
Original change's description:
Bug: 904000
Change-Id: I507ec17eabc8e323a7c6418075d4be4787d4c5df
Reviewed-on: https://chromium-review.googlesource.com/c/1378805
Reviewed-by: Joshua Bell <[email protected]>
Commit-Queue: Jarryd Goodman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#617285}