Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make testharness tests run in a top-level browsing context" #14496

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Revert "Make testharness tests run in a top-level browsing context" #14496

merged 1 commit into from
Dec 13, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented Dec 13, 2018

This reverts commit 74522a2.

Fixes #14495.

Reopens #13418.

@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run wptserve labels Dec 13, 2018
@foolip
Copy link
Member Author

foolip commented Dec 13, 2018

I will wait for CI to finish running here, but I'll admin merge without review when they're green.

@foolip foolip mentioned this pull request Dec 13, 2018
Merged
@foolip
Copy link
Member Author

foolip commented Dec 13, 2018

Note that despite the branch name, this is not a full revert of #13966 but just of the main commit.

@foolip
Copy link
Member Author

foolip commented Dec 13, 2018

Crap, test_run_firefox is failing on Travis:
https://travis-ci.org/web-platform-tests/wpt/jobs/467412785#L629

I sort of doubt it's because of the changes since I saw something similar yesterday, but I've sent #14500 to run all the tools/ tests before I merge this, to see if there are failures on master.

@foolip foolip merged commit 9377b49 into master Dec 13, 2018
@foolip foolip deleted the foolip/revert-13966 branch December 13, 2018 09:47
This was referenced Dec 13, 2018
Closed
Closed
@foolip
Copy link
Member Author

foolip commented Dec 13, 2018

#14500 was passing. I'll retrigger again with my revert included to see if it goes to failing. If it does then the problem is real. (Or it's flaky and I'm unlucky.)

@foolip
Copy link
Member Author

foolip commented Dec 13, 2018

Still passing. That test must be flaky then. @jgraham can you tell from https://travis-ci.org/web-platform-tests/wpt/jobs/467412785#L629 if it was due to mozdownload failing, or what's up?

@jgraham
Copy link
Contributor

jgraham commented Dec 13, 2018

It's not the download, it's the websockets server not starting for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnedders gsnedders Awaiting requested review from gsnedders

@jgraham jgraham Awaiting requested review from jgraham

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

Assignees

@jgraham jgraham

Labels
infra wptrunner The automated test runner, commonly called through ./wpt run wptserve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foolip @jgraham @wpt-pr-bot