[WebLocks]: Modifying weblocks algos to be O(1) #14420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 7, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1367910
branch
6 times, most recently
from
8704a74 to
ddf82d8
Compare
foolip
force-pushed
the
chromium-export-cl-1367910
branch
from
ddf82d8 to
1ed5ba2
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1367910
branch
6 times, most recently
from
088bcb6 to
a384ace
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1367910
branch
from
a384ace to
184c86f
Compare
The behaviour of the request/release operations of web locks are modified to be O(1) instead of their currently O(n) worst case runtime. Additionally the query-order wpt is modified to reflect the new spec requirement that the state returned by navigator.locks.query need only respect ordering for requested locks per resource. Bug: 913014 Change-Id: I819f8c27c995cb698a7c8b2c75ee80d32c744f07 Spec: https://wicg.github.io/web-locks/#algorithms Reviewed-on: https://chromium-review.googlesource.com/c/1367910 Commit-Queue: Andreas Butler <[email protected]> Reviewed-by: Victor Costan <[email protected]> Reviewed-by: Joshua Bell <[email protected]> Reviewed-by: Daniel Murphy <[email protected]> Cr-Commit-Position: refs/heads/master@{#621833}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1367910
branch
from
184c86f to
30e2738
Compare
|
Blocked on chrome instability:
Both of these results were already flaky: |
|
I've investigated and filed #15015, pretty hopeful it can be fixed. The test in question wasn't changed by this PR, only affected by the change to helpers.js, so I'll go ahead and admin merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour of the request/release operations of web locks are
modified to be O(1) instead of their currently O(n) worst case runtime.
Additionally the query-order wpt is modified to reflect the new spec
requirement that the state returned by navigator.locks.query need only
respect ordering for requested locks per resource.
Bug: 913014
Change-Id: I819f8c27c995cb698a7c8b2c75ee80d32c744f07
Spec: https://wicg.github.io/web-locks/#algorithms
Reviewed-on: https://chromium-review.googlesource.com/c/1367910
Commit-Queue: Andreas Butler <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Reviewed-by: Joshua Bell <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#621833}