Fixes to the plugin-types csp checks and added empty directive check #14339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 3, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1358457
branch
from
2e48287 to
fac30ba
Compare
Fixed the external/wpt/content-security-policyplugin-types tests as the current ones are actually entirely useless as they pretty much always pass. Discovered and raised crbug.com/911114, also skipping the (now correct) tests that uncovered this issue. Added new test for empty plugin-types directive blocking every plugin. Removed tests in http/tests/security/contentSecurityPolicy that are direct 1-to-1 equivalents of these tests. Spec: w3c/webappsec-csp#374 Bug: 694525 Change-Id: I91a548c6035a82310be077501934a51cf85525a2 Reviewed-on: https://chromium-review.googlesource.com/c/1358457 Commit-Queue: Andy Paicu <[email protected]> Reviewed-by: Mike West <[email protected]> Cr-Commit-Position: refs/heads/master@{#613517}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1358457
branch
from
fac30ba to
3950f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the external/wpt/content-security-policyplugin-types tests as the
current ones are actually entirely useless as they pretty much always
pass.
Discovered and raised crbug.com/911114, also skipping the (now correct)
tests that uncovered this issue.
Added new test for empty plugin-types directive blocking every plugin.
Removed tests in http/tests/security/contentSecurityPolicy that are
direct 1-to-1 equivalents of these tests.
Spec: w3c/webappsec-csp#374
Bug: 694525
Change-Id: I91a548c6035a82310be077501934a51cf85525a2
Reviewed-on: https://chromium-review.googlesource.com/c/1358457
Commit-Queue: Andy Paicu <[email protected]>
Reviewed-by: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#613517}