[css-text] Update 'line-break' tests #14334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Fix test file name numbering
The problem was that `line-break-normal-*` and `line-break-strict-*` had diffrent numbering for same ranges, e.g. `line-break-normal-021` and `line-break-strict-014` for same iteration marks. It was confusing, so I changed the numbering for 'normal' to be the same as for 'strict'.
- line-break-normal-021 → line-break-normal-014
- line-break-normal-022 → line-break-normal-015
- line-break-normal-023a → line-break-normal-016a
- line-break-normal-023b → line-break-normal-016b
- line-break-normal-024a → line-break-normal-017a
- line-break-normal-024b → line-break-normal-017b
### Fix tests for Inseparatable characters
The tests for Inseparatable characters `line-break-strict-015` and `line-break-normal-015` (was `line-break-normal-022`) had wrong assertion "does not allow line breaking **before** inseparable characters". This should be "does not allow line breaking **between** inseparable characters".
I changed the tests to test line breaking **between** (not **before**) two inseparable characters.
### Fix tests for Centered punctuation marks
The tests for Centered punctuation marks `line-break-strict-016a` and `line-break-normal-016a` (was `line-break-normal-023a`) contained tests for EAW=Narrow characters (U+003A, U+003B, U+0021, U+003F) that are excluded in the current 'line-break' spec.
### Fix tests for Postfixes
The tests for Postfixes `line-break-strict-017a` and `line-break-normal-017a` (was `line-break-normal-024a`) contained tests for EAW=Narrow characters (U+0025 and U+00A2) that are excluded in the current 'line-break' spec.
### Add tests for Prefixes
Added the tests for line breaking after Prefixes `line-break-*-018`.
### Add 'loose' and 'normal' values tests that were missing
- line-break-loose-011 .. line-break-loose-017b
- line-break-normal-011 .. line-break-normal-013
### Adjust width of the test block
I changed the width of the test block `p.test, p.control {...}` that was `width: 10em` to `width: 10.2em`. This extra (.2em) width is needed to prevent unexpected line breaking caused by some symbol characters wider than 1em.
I found this problem with `line-break-loose-018`. The width of U+2116 "№" is slightly wider than 1em and if the block width is 10em the line breaking occurs before that character�, and the test always fails.
wpt-pr-bot
requested review from
fantasai,
frivoal,
hakatashi,
kojiishi,
nox,
plinss and
r12a
r12a
reviewed
Dec 3, 2018
There was a problem hiding this comment.
I don't currently have time to review these tests properly, but i'll just note that i have similar-looking tests at https://w3c.github.io/i18n-tests/results/line-breaks-jazh (click on the link in the left column to run the tests). I note that because my tests produce js-based results - you may want to consider doing something similar, rather than making these manual tests (iiuc).
|
This pull request is not for adding new tests, but for updating existing css/css-text/line-break/ tests that were made in early 2011. The css-text-3 'line-break' spec has been changed since then but these tests had not been updated. In this PR, I updated the outdated tests and also added some missing tests. @r12a Yes, these tests are similar to your https://w3c.github.io/i18n-tests/results/line-breaks-jazh (thanks!), but non-JavaScript and can be used to test layout engines without JavaScript. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test file name numbering
The problem was that
line-break-normal-*andline-break-strict-*had diffrent numbering for same ranges, e.g.line-break-normal-021andline-break-strict-014for same iteration marks. It was confusing, so I changed the numbering for 'normal' to be the same as for 'strict'.Fix tests for Inseparatable characters
The tests for Inseparatable characters
line-break-strict-015andline-break-normal-015(wasline-break-normal-022) had wrong assertion "does not allow line breaking before inseparable characters". This should be "does not allow line breaking between inseparable characters".I changed the tests to test line breaking between (not before) two inseparable characters.
Fix tests for Centered punctuation marks
The tests for Centered punctuation marks
line-break-strict-016aandline-break-normal-016a(wasline-break-normal-023a) contained tests for EAW=Narrow characters (U+003A, U+003B, U+0021, U+003F) that are excluded in the current 'line-break' spec.Fix tests for Postfixes
The tests for Postfixes
line-break-strict-017aandline-break-normal-017a(wasline-break-normal-024a) contained tests for EAW=Narrow characters (U+0025 and U+00A2) that are excluded in the current 'line-break' spec.Add tests for Prefixes
Added the tests for line breaking after Prefixes
line-break-*-018.Add 'loose' and 'normal' values tests that were missing
Adjust width of the test block
I changed the width of the test block
p.test, p.control {...}that waswidth: 10emtowidth: 10.2em. This extra (.2em) width is needed to prevent unexpected line breaking caused by some symbol characters wider than 1em.I found this problem with
line-break-loose-018. The width of U+2116 "№" is slightly wider than 1em and if the block width is 10em the line breaking occurs before that character, and the test always fails.