Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test PaymentMethodData data member is converted in constructor #14205

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Test PaymentMethodData data member is converted in constructor #14205

merged 2 commits into from
Nov 28, 2018

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres mentioned this pull request Nov 23, 2018
Closed
7 tasks
zouhir
zouhir approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@zouhir zouhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@marcoscaceres
Copy link
Contributor Author

Thanks @zouhir! If you'll like to check the test in Edge:
https://w3c-test.org/submissions/14205/payment-request/constructor_convert_method_data.https.html

@zouhir
Copy link
Member

zouhir commented Nov 26, 2018

Yep, will do! @marcoscaceres

@web-platform-tests web-platform-tests deleted a comment Nov 27, 2018
zouhir
zouhir approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@zouhir zouhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfect and spread object property issue fixed.

@marcoscaceres marcoscaceres merged commit 15d978a into master Nov 28, 2018
@marcoscaceres marcoscaceres deleted the convert_modifiers branch November 29, 2018 10:40
This was referenced Jan 29, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zouhir zouhir zouhir approved these changes

@domenic domenic Awaiting requested review from domenic

@edenchuang edenchuang Awaiting requested review from edenchuang

@mnoorenberghe mnoorenberghe Awaiting requested review from mnoorenberghe

@romandev romandev Awaiting requested review from romandev

@rsolomakhin rsolomakhin Awaiting requested review from rsolomakhin

Assignees

@rsolomakhin rsolomakhin

Labels
payment-request wg-payments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoscaceres @zouhir @rsolomakhin @wpt-pr-bot