[BlinkGenPropertyTrees] Filter effects should be clipped #14153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 20, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1344217
branch
from
b17abe6 to
162a229
Compare
According to the spec, filtering should apply before clipping (https://drafts.fxtf.org/css-masking-1/#placement): "...effects are applied to the element in order: filter effects, clipping, masking and opacity." This patch fixes clip-path order with BlinkGenPropertyTrees (BGPT) which exposed the issue of filter and clip order. Testcases have been added showing the fixed behavior with BGPT, and the non-BGPT results have been marked as failing. NOTRY=true Bug: 906154, 907175 Change-Id: I5e9c7dbb7c694afc623fbc3bb2c7f2f8cc458195 Reviewed-on: https://chromium-review.googlesource.com/c/1344217 Commit-Queue: Philip Rogers <[email protected]> Reviewed-by: Xianzhu Wang <[email protected]> Cr-Commit-Position: refs/heads/master@{#609847}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1344217
branch
from
162a229 to
96ab4cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec, filtering should apply before clipping
(https://drafts.fxtf.org/css-masking-1/#placement): "...effects are applied to
the element in order: filter effects, clipping, masking and opacity."
This patch fixes clip-path order with BlinkGenPropertyTrees (BGPT) which exposed
the issue of filter and clip order. Testcases have been added showing the fixed
behavior with BGPT, and the non-BGPT results have been marked as failing.
NOTRY=true
Bug: 906154, 907175
Change-Id: I5e9c7dbb7c694afc623fbc3bb2c7f2f8cc458195
Reviewed-on: https://chromium-review.googlesource.com/c/1344217
Commit-Queue: Philip Rogers <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#609847}