-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow test_driver.bless
to work when running manually
#14073
Conversation
Tests using `test_driver.bless` now currently always fail when running them manually, because the default `test_driver_internal.click` rejects with "unimplemented". Mute the rejection if the session isn't controlled by WebDriver, which we check with `navigator.webdriver`.
This is an alternative to #11173, and only fixes |
I'm somewhat concerned about the use of the |
I'd be happy to use any other signal we have that we're being controlled by wptrunner. Do we have something else we could use? |
The answer is straightforward I think: use |
@foolip does this work for |
@gsnedders, no, but there we'll replace |
@jugglinmike, do you intend to get #11173 landed? If that's not imminent I'd like to land something simple like this PR that makes manual testing possible. |
I'd like to land gh-11173. I've just updated it in an attempt to satisfy the remaining concerns. |
All right, reviewing that. |
Tests using
test_driver.bless
now currently always fail when runningthem manually, because the default
test_driver_internal.click
rejects with "unimplemented".
Mute the rejection if the session isn't controlled by WebDriver, which
we check with
navigator.webdriver
.