[Gecko Bug 1502864] webdriver: add tests for keyboard interactability for <input type=file #13885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 3, 2018
|
@jgraham This was backed out of central, then pushed again to autoland, then @wpt-pr-bot closed this PR without merging it. How does it handle a re-landing? |
Normally all interactability tests are centralised in interactability.py, but the WebDriver standard recently changed to apply a special set of interactability checks specifically for <input type=file>. These tests ensure the special code paths are invoked for form controls. Differential Revision: https://phabricator.services.mozilla.com/D10269 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1502864 gecko-commit: 301c1d1d5e14f001e373b329de611460a177dec8 gecko-integration-branch: central gecko-reviewers: jgraham
The WebDriver standard changed in w3c/webdriver#1325 to align with chromedriver's behaviour of permitting interaction with hidden <input type=file> elements. DOM elements can be hidden, i.e. not rendered, in two ways: through applying the "hidden" DOM attribute or by setting the "display: none" CSS style. Depends on D10269 Depends on D10269 Differential Revision: https://phabricator.services.mozilla.com/D10270 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1502864 gecko-commit: 6fb763dc8e9b832ddd4aa24179b74db94a229c35 gecko-integration-branch: central gecko-reviewers: jgraham, whimboo
The new strictFileInteractabilityTests capability takes a boolean and can unconditionally be set to both true and false. It is permitted to be undefined. Depends on D10270 Depends on D10270 Differential Revision: https://phabricator.services.mozilla.com/D10271 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1502864 gecko-commit: dc69c736701f2b7b405e50ed92e3384e44e233c7 gecko-integration-branch: central gecko-reviewers: jgraham
Depends on D10271 Depends on D10271 Differential Revision: https://phabricator.services.mozilla.com/D10272 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1502864 gecko-commit: 7a89ca7dca2d3df428a4a8d94c31cd5c48af3162 gecko-integration-branch: central gecko-reviewers: jgraham
moz-wptsync-bot
force-pushed
the
gecko/1502864
branch
from
8c86034 to
49cdc59
Compare
|
nm, looks like it will! |
|
Impossible to tell from the log what is going on because: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally all interactability tests are centralised in interactability.py,
but the WebDriver standard recently changed to apply a special
set of interactability checks specifically for .
These tests ensure the special code paths are invoked for form controls.
Differential Revision: https://phabricator.services.mozilla.com/D10269
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1502864
gecko-commit: 7616e25a07b38086a8a615be0158e93cbaa0a59a
gecko-integration-branch: central
gecko-reviewers: jgraham