[Background Fetch] Simplify fetch storage workflow. #13528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 15, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1280851
branch
10 times, most recently
from
71d65e1 to
71304cd
Compare
In addition, MatchAll should return all records, including unprocessed ones. To support this, the following changes were made: - Creating a registration also stores all the requests with an empty response in the cache. - When an individual request is processed, the failure reason (if any) is stored in the metadata. - The logic of GetSettledFetchesTask was moved to MarkRegistrationForDeletionTask. It checks the metadata rather than the cache itself to find a failure reason (if any). - Match/MatchAll logic was moved to a new database task (MatchRequestsTask). A new API call was added to the cache storage to allow querying request/response pairs. If a response is found to be empty it will be exposed as a nullptr. Change-Id: I631a3ef3da95117aed759a675fe591da5201eeca Reviewed-on: https://chromium-review.googlesource.com/c/1280851 Reviewed-by: Peter Beverloo <[email protected]> Reviewed-by: Steven Holte <[email protected]> Reviewed-by: Joshua Bell <[email protected]> Reviewed-by: Ben Kelly <[email protected]> Reviewed-by: Mugdha Lakhani <[email protected]> Commit-Queue: Rayan Kanso <[email protected]> Cr-Commit-Position: refs/heads/master@{#600768}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1280851
branch
from
71304cd to
27ebdcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, MatchAll should return all records, including unprocessed
ones. To support this, the following changes were made:
response in the cache.
is stored in the metadata.
MarkRegistrationForDeletionTask. It checks the metadata rather than the
cache itself to find a failure reason (if any).
(MatchRequestsTask). A new API call was added to the cache storage to
allow querying request/response pairs. If a response is found to be
empty it will be exposed as a nullptr.
Change-Id: I631a3ef3da95117aed759a675fe591da5201eeca
Reviewed-on: https://chromium-review.googlesource.com/c/1280851
Reviewed-by: Peter Beverloo <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Joshua Bell <[email protected]>
Reviewed-by: Ben Kelly <[email protected]>
Reviewed-by: Mugdha Lakhani <[email protected]>
Commit-Queue: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/heads/master@{#600768}