[Gecko Bug 1498148] Implement text-transform: full-size-kana. #13504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 13, 2018
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1498148 gecko-commit: 410f1ce46d58faaa90983efe0805b798df57c43e gecko-integration-branch: mozilla-inbound gecko-reviewers: xidorn
moz-wptsync-bot
force-pushed
the
gecko/1498148
branch
from
3b8eebe to
0b0b522
Compare
frivoal
previously requested changes
Oct 13, 2018
There was a problem hiding this comment.
The tests themselves look correct, but the comments in them are misleading (see comment inline). This should be fixed first.
Other than that, -001 overlaps with the tests proposed in #13461, but -002 is different, so I guess having both is fine.
| <span title="U+FF6E">ﾖ ﾖ</span> | ||
| </div> | ||
| <!--Notes: | ||
| Tip: To identify the characters where differences occur, in order to report problem characters, either mouse over to reveal a tooltip, or copy and paste the sequence into a tool such as <a href='http://r12a.github.io/uniview/' target='_blank'>UniView</a> or the <a href='http://r12a.github.io/apps/conversion/' target='_blank'>Unicode Conversion Tool</a>. |
There was a problem hiding this comment.
This tip is not correct. copy&paste should copy the original untransformed character, so Uniview won't help. (same comment in other tests).
Spec reference for that claim:
https://drafts.csswg.org/css-text-3/#text-transform-property
This property transforms text for styling purposes. It has no effect on the underlying content, and must not affect the content of a plain text copy & paste operation.
|
Turns out the incorrect tip is shared between plenty of tests. Unblocking this PR in favor of this new issue to fix them all. |
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Oct 15, 2018
Rework the tests from web-platform-tests#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Oct 16, 2018
Rework the tests from web-platform-tests#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Dec 26, 2018
Rework the tests from web-platform-tests#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 5, 2019
…ize-kana, a=testonly Automatic update from web-platform-tests [css-text] Improve text-transform:full-size-kana tests Rework the tests from web-platform-tests/wpt#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything -- Merge pull request #13461 from frivoal/text-3143 [css-text] Test for text-tranform:full-size-kana -- wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508 wpt-pr: 13461
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Feb 6, 2019
…ize-kana, a=testonly Automatic update from web-platform-tests [css-text] Improve text-transform:full-size-kana tests Rework the tests from web-platform-tests/wpt#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything -- Merge pull request #13461 from frivoal/text-3143 [css-text] Test for text-tranform:full-size-kana -- wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508 wpt-pr: 13461
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 7, 2019
…ize-kana, a=testonly Automatic update from web-platform-tests [css-text] Improve text-transform:full-size-kana tests Rework the tests from web-platform-tests/wpt#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything -- Merge pull request #13461 from frivoal/text-3143 [css-text] Test for text-tranform:full-size-kana -- wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508 wpt-pr: 13461
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Feb 8, 2019
…ize-kana, a=testonly Automatic update from web-platform-tests [css-text] Improve text-transform:full-size-kana tests Rework the tests from web-platform-tests/wpt#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything -- Merge pull request #13461 from frivoal/text-3143 [css-text] Test for text-tranform:full-size-kana -- wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508 wpt-pr: 13461
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…ize-kana, a=testonly Automatic update from web-platform-tests [css-text] Improve text-transform:full-size-kana tests Rework the tests from web-platform-tests/wpt#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything -- Merge pull request #13461 from frivoal/text-3143 [css-text] Test for text-tranform:full-size-kana -- wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508 wpt-pr: 13461 UltraBlame original commit: 3765db1858e18db83c48a358e39824ea2c5dccc8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…ize-kana, a=testonly Automatic update from web-platform-tests [css-text] Improve text-transform:full-size-kana tests Rework the tests from web-platform-tests/wpt#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything -- Merge pull request #13461 from frivoal/text-3143 [css-text] Test for text-tranform:full-size-kana -- wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508 wpt-pr: 13461 UltraBlame original commit: 9fabbd4a66fdcfe0ef0b2280fd6cf1dbbbc21676
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…ize-kana, a=testonly Automatic update from web-platform-tests [css-text] Improve text-transform:full-size-kana tests Rework the tests from web-platform-tests/wpt#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything -- Merge pull request #13461 from frivoal/text-3143 [css-text] Test for text-tranform:full-size-kana -- wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508 wpt-pr: 13461 UltraBlame original commit: 3765db1858e18db83c48a358e39824ea2c5dccc8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…ize-kana, a=testonly Automatic update from web-platform-tests [css-text] Improve text-transform:full-size-kana tests Rework the tests from web-platform-tests/wpt#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything -- Merge pull request #13461 from frivoal/text-3143 [css-text] Test for text-tranform:full-size-kana -- wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508 wpt-pr: 13461 UltraBlame original commit: 9fabbd4a66fdcfe0ef0b2280fd6cf1dbbbc21676
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…ize-kana, a=testonly Automatic update from web-platform-tests [css-text] Improve text-transform:full-size-kana tests Rework the tests from web-platform-tests/wpt#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything -- Merge pull request #13461 from frivoal/text-3143 [css-text] Test for text-tranform:full-size-kana -- wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508 wpt-pr: 13461 UltraBlame original commit: 3765db1858e18db83c48a358e39824ea2c5dccc8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…ize-kana, a=testonly Automatic update from web-platform-tests [css-text] Improve text-transform:full-size-kana tests Rework the tests from web-platform-tests/wpt#13504, so that: * They fit within 600px × 600px (as generally required for reftests) * They are easier for a human reader to review: being asked whether two characters are the same when the only difference expected is size is much easier if you have a reference for the right and wrong size. Only doing this in tests 001 to 004, as for the rest there's not (always) a corresponding small character. * The test that check that nothing happens on already full-size kana only applies the (ineffective) transform to one character in each pair as otherwise, it isn't really testing anything -- Merge pull request #13461 from frivoal/text-3143 [css-text] Test for text-tranform:full-size-kana -- wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508 wpt-pr: 13461 UltraBlame original commit: 9fabbd4a66fdcfe0ef0b2280fd6cf1dbbbc21676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1498148
gecko-commit: a00b402fb8e82ca4f1c25923be8095b5dfbcf626
gecko-integration-branch: mozilla-inbound
gecko-reviewers: xidorn