Support ./wpt run --channel=preview safari
#13460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly to avoid the lengthy argument currently required: `--webdriver-binary "/Applications/Safari Technology Preview.app/Contents/MacOS/safaridriver"` Using `--browser-channel=preview` and the product `safari_webdriver` also works.
wpt-pr-bot
requested review from
dontcallmedom,
gsnedders,
jgraham and
sideshowbarker
|
Stern suggestions about how to test this appreciated. |
|
(I have tested it locally, and it works!) |
jgraham
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly to avoid the lengthy argument currently required:
--webdriver-binary "/Applications/Safari Technology Preview.app/Contents/MacOS/safaridriver"Using
--browser-channel=previewand the productsafari_webdriveralso works.