Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12876: set -ex on ci_taskcluster.sh #12878

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Fix #12876: set -ex on ci_taskcluster.sh #12878

merged 1 commit into from
Sep 7, 2018

Conversation

gsnedders
Copy link
Member

No description provided.

@wpt-pr-bot wpt-pr-bot requested a review from jgraham September 6, 2018 18:12
@jgraham
Copy link
Contributor

jgraham commented Sep 6, 2018

Note that #12657 removes this file.

@gsnedders
Copy link
Member Author

This makes a real difference to debugging TC failures, and makes TC fail properly. I think this is important enough that we should land it even if the code is soon going to become obsolete.

@Ms2ger Ms2ger merged commit d9e0776 into web-platform-tests:master Sep 7, 2018
@gsnedders gsnedders deleted the tc-set-ex branch September 7, 2018 16:22
@jugglinmike jugglinmike mentioned this pull request Sep 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@jgraham jgraham Awaiting requested review from jgraham

Assignees
No one assigned
Labels
ci infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsnedders @jgraham @Ms2ger @wpt-pr-bot