Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts to extract xhr test suite metadata, annotate spec #1272

Closed
wants to merge 3 commits into from

Conversation

hallvors
Copy link
Contributor

@hallvors hallvors commented Oct 6, 2014

Nearly all tests in the XHR test suite have (potentially outdated) meta data linking them to specific assertations in the spec. (Technically this is a set of space-separated XPath expressions for each link @rel=help element which, combined with the section linked to from the HREF, identifies a given assertation).

Here's some code to actually make use of this data. One Python script to extract the meta data into a single JSON file, and one javascript to iterate over the resulting JSON data and annotate the spec.

To test, load http://www.w3.org/TR/XMLHttpRequest/ and run this from the browser's dev tools' console:

document.body.appendChild(document.createElement('script')).src='http://hallvord.com/temp/xhr/annotate_spec.js'

You may have to disable mixed content blocking in your browser if the spec loads over https.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/2772

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@hallvors
Copy link
Contributor Author

hallvors commented Oct 6, 2014

(I have no idea why Travis "build" fails)

@hallvors
Copy link
Contributor Author

hallvors commented Oct 6, 2014

To be clear: the expected effect of running the script is

  1. Every assertation that have at least one associated test, get a light green background
  2. One or more link(s) to relevant test(s) are added after each assertation.

@ayg ayg closed this Aug 28, 2016
@ayg ayg deleted the hallvors/xhr_metadata_extractor branch August 28, 2016 13:58
@gsnedders gsnedders restored the hallvors/xhr_metadata_extractor branch August 28, 2016 20:17
@gsnedders
Copy link
Member

15:01 < aryehgregor> Um, I might have done something wrong by mistake.
15:01 < aryehgregor> I think I pushed to the wrong repo?

@gsnedders gsnedders reopened this Aug 28, 2016
@ayg ayg closed this Oct 26, 2016
@ayg ayg deleted the hallvors/xhr_metadata_extractor branch October 26, 2016 17:38
@ayg ayg restored the hallvors/xhr_metadata_extractor branch October 26, 2016 18:04
@ayg ayg reopened this Oct 26, 2016
@annevk
Copy link
Member

annevk commented Feb 20, 2017

Note whatwg/xhr#119 which proposes closing this PR.

@wpt-pr-bot
Copy link
Collaborator

@annevk annevk closed this Feb 23, 2017
@annevk annevk deleted the hallvors/xhr_metadata_extractor branch February 23, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants