[css-counter-styles] Add prefix and suffix tests #11886
Conversation
|
Hmm... We already have quite a bit of tests in https://github.com/web-platform-tests/wpt/tree/master/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3 do we need more? |
|
Ah, I didn't know that directory. IIUC it has already covered the tests in my PR... |
|
I guess we can close this then? I don't see much value adding another set of tests for the same functionality. |
Fine with me. |
| </div> | ||
| <!--Notes: | ||
| You will need an appropriate font to run this test. | ||
| To see the ASCII decimal number associated with a row, mouse over it and the number will pop up in a tooltip. |
There was a problem hiding this comment.
This comment is wrong - there's only a title on the ref, not the test.
| <ol start="10"><li><span class="blank">x</span></li></ol> | ||
| <ol start="12"><li><span class="blank">x</span></li></ol> | ||
| <ol start="222"><li><span class="blank">x</span></li></ol> | ||
| <ol start="9999"><li><span class="blank">x</span></li></ol> |
There was a problem hiding this comment.
Slightly odd that this is testing additive itself at the same time as testing the default suffix. Surely it only needs one line?
| <ol start="9999"><li><span class="blank">x</span></li></ol> | ||
| </div> | ||
| <!--Notes: | ||
| You will need an appropriate font to run this test. |
There was a problem hiding this comment.
Why is this test using characters with spotty font coverage? That's not what this is trying to test in the first place; it seems this could be rewritten to just use ASCII.
This PR ports https://w3c.github.io/i18n-tests/results/counter-styles#affixes to WPT.