Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome fails infrastructure/testdriver/actions/actionsWithKeyPressed.html on Mac #17296

Closed
georgeroman opened this issue Jun 12, 2019 · 5 comments

Comments

@georgeroman
Copy link
Contributor

georgeroman commented Jun 12, 2019

#17212 fails the infrastructure tests due to an unrelated test failure occurring in actionsWithKeyPressed.html. It seems that this test was added quite recently: #16475.

 ▶ Unexpected subtest result in /infrastructure/testdriver/actions/actionsWithKeyPressed.html:
  │ FAIL [expected PASS] TestDriver actions: actions with key pressed
  │   → assert_array_equals: lengths differ, expected 3 got 1
  │ 
  │     at Test.<anonymous> (http://web-platform.test:8000/infrastructure/testdriver/actions/actionsWithKeyPressed.html:64:34)
  │     at Test.step (http://web-platform.test:8000/resources/testharness.js:1594:25)
  └     at http://web-platform.test:8000/resources/testharness.js:1634:32
@Hexcles
Copy link
Member

Hexcles commented Jun 19, 2019

I checked out #17212 and couldn't find this failure. Did it go away after you retried/rebased?

@georgeroman
Copy link
Contributor Author

georgeroman commented Jun 19, 2019

@Hexcles Hexcles changed the title Failing ChromeDriver test: infrastructure/testdriver/actions/actionsWithKeyPressed.html Chrome fails infrastructure/testdriver/actions/actionsWithKeyPressed.html on Mac Jun 20, 2019
Hexcles added a commit that referenced this issue Jun 20, 2019
Related to issue #17296. This PR does not fix the underlying issue, but
only unblocks the infrastructure tests on macOS.
Hexcles added a commit that referenced this issue Jun 20, 2019
Related to issue #17296. This PR does not fix the underlying issue, but
only unblocks the infrastructure tests on macOS.
Hexcles added a commit that referenced this issue Jun 20, 2019
Related to issue #17296. This PR does not fix the underlying issue, but
only unblocks the infrastructure tests on macOS.
@Hexcles
Copy link
Member

Hexcles commented Jun 20, 2019

infrastructure/testdriver/actions/elementPosition.html also fails on Chrome for macOS.

gsnedders pushed a commit that referenced this issue Jun 21, 2019
Related to issue #17296. This PR does not fix the underlying issue, but
only unblocks the infrastructure tests on macOS.
marcoscaceres pushed a commit that referenced this issue Jul 23, 2019
Related to issue #17296. This PR does not fix the underlying issue, but
only unblocks the infrastructure tests on macOS.
@Hexcles
Copy link
Member

Hexcles commented Sep 11, 2019

Reopening this because #17415 did not fix the issue, but only worked around it.

@stephenmcgruer
Copy link
Contributor

So the entire directory was skipped in #18934 (Sep 2019), due to https://bugs.chromium.org/p/chromedriver/issues/detail?id=3114

Then https://bugs.chromium.org/p/chromedriver/issues/detail?id=3114 was fixed in #19555 (Oct 2019) and the tests re-enabled in #19497

In short, this seems fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants