Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining module credential tests to write #13426

Open
4 of 5 tasks
domenic opened this issue Oct 8, 2018 · 0 comments
Open
4 of 5 tasks

Remaining module credential tests to write #13426

domenic opened this issue Oct 8, 2018 · 0 comments
Assignees
@domfarolino
Labels
html type:missing-coverage workers

Comments

@domenic
Copy link
Member

domenic commented Oct 8, 2018 •
edited
Loading

Porting this from @domfarolino's investigative work on whatwg/html#3656 (comment). Some work landed in #11274 and #13176, but for thorough coverage, we should also test:

  • Default <link rel=modulepreload> credentials mode, and the affect of crossorigin="" on it
  • Default credentials mode for module worker descendant imports (static and dynamic), and the affect of the credentials Worker constructor option on it
  • Default credentials mode for classic worker descendant dynamic imports (cannot be changed)
  • Default credentials mode for javascript: URL dynamic imports (cannot be changed)
  • Ensure that cross-origin module workers are not supported (despite existing for a brief period in the spec)

And as a bonus, not really related to modules:

  • Default credentials mode for classic worker importScripts(). Per the spec I guess this is "omit"? I might be reading it wrong though.
domenic pushed a commit to whatwg/html that referenced this issue Oct 9, 2018
@annevk @domenic
Change how module scripts are fetched
5fabb58 
* Module scripts are always fetched with request credentials mode
  "same-origin" by default, instead of the previous default of "omit".
  Only worker module scripts can still set that to "omit", using the
  credentials option to the Worker constructor. Non-worker module
  scripts, which only have the crossorigin="" attribute available, can
  only toggle between "same-origin" and "include", similar to how
  crossorigin="" works for other platform features.
* Similarly, import() statements inside of classic scripts now use the
  "same-origin" credentials mode, instead of "omit". This affects both
  <script> elements, where the default can be changed using
  crossorigin="", and other contexts like javascript: URLs and classic
  worker scripts, where the default cannot be changed.
* The top-level script for module workers is always fetched with request
  mode "same-origin". Cross-origin workers did not quite work due to
  service workers.

Fixes #2557. Fixes #3109.

Tests:

* web-platform-tests/wpt#11274
* web-platform-tests/wpt#13176
* web-platform-tests/wpt#13426
@domfarolino domfarolino self-assigned this Oct 16, 2018
This was referenced Oct 23, 2018
Merged
Merged
chromium-wpt-export-bot pushed a commit that referenced this issue Oct 26, 2018
@domfarolino @chromium-wpt-export-bot
Change default classic script fetch options credentials mode
ae48f07 
This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: #13426

[email protected], [email protected], [email protected]

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
Merged
chromium-wpt-export-bot pushed a commit that referenced this issue Oct 26, 2018
@domfarolino @chromium-wpt-export-bot
Change default classic script fetch options credentials mode
38e77a7 
This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: #13426

[email protected], [email protected], [email protected]

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
chromium-wpt-export-bot pushed a commit that referenced this issue Nov 2, 2018
@domfarolino @chromium-wpt-export-bot
Change default classic script fetch options credentials mode
86c43e8 
This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: #13426

[email protected], [email protected], [email protected]

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
aarongable pushed a commit to chromium/chromium that referenced this issue Nov 2, 2018
@domfarolino
Change default classic script fetch options credentials mode
ddb23f2 
This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: web-platform-tests/wpt#13426

[email protected], [email protected], [email protected]

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
Reviewed-on: https://chromium-review.googlesource.com/c/1301964
Commit-Queue: Dominic Farolino <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604862}
chromium-wpt-export-bot pushed a commit that referenced this issue Nov 2, 2018
@domfarolino @chromium-wpt-export-bot
Change default classic script fetch options credentials mode
21cd6f0 
This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: #13426

[email protected], [email protected], [email protected]

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
Reviewed-on: https://chromium-review.googlesource.com/c/1301964
Commit-Queue: Dominic Farolino <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604862}
chromium-wpt-export-bot pushed a commit that referenced this issue Nov 2, 2018
@domfarolino @chromium-wpt-export-bot
Change default classic script fetch options credentials mode
085c8a8 
This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: #13426

[email protected], [email protected], [email protected]

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
Reviewed-on: https://chromium-review.googlesource.com/c/1301964
Commit-Queue: Dominic Farolino <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604862}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 10, 2018
@domfarolino @moz-wptsync-bot
Bug 1502443 [wpt PR 13739] - Change default classic script fetch opti…
573eea3 
…ons credentials mode, a=testonly

Automatic update from web-platform-testsChange default classic script fetch options credentials mode

This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: web-platform-tests/wpt#13426

[email protected], [email protected], [email protected]

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
Reviewed-on: https://chromium-review.googlesource.com/c/1301964
Commit-Queue: Dominic Farolino <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604862}

--

wpt-commits: 085c8a8f6eab33c6586d4d1f9897b700f41c8f54
wpt-pr: 13739
jyc pushed a commit to jyc/gecko that referenced this issue Nov 11, 2018
@domfarolino @moz-wptsync-bot
Bug 1502443 [wpt PR 13739] - Change default classic script fetch opti…
4b8d182 
…ons credentials mode, a=testonly

Automatic update from web-platform-testsChange default classic script fetch options credentials mode

This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: web-platform-tests/wpt#13426

[email protected], [email protected], [email protected]

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
Reviewed-on: https://chromium-review.googlesource.com/c/1301964
Commit-Queue: Dominic Farolino <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604862}

--

wpt-commits: 085c8a8f6eab33c6586d4d1f9897b700f41c8f54
wpt-pr: 13739
@domfarolino domfarolino mentioned this issue Nov 20, 2018
Merged
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@annevk @mustaqahmed
Change how module scripts are fetched
b36454f 
* Module scripts are always fetched with request credentials mode
  "same-origin" by default, instead of the previous default of "omit".
  Only worker module scripts can still set that to "omit", using the
  credentials option to the Worker constructor. Non-worker module
  scripts, which only have the crossorigin="" attribute available, can
  only toggle between "same-origin" and "include", similar to how
  crossorigin="" works for other platform features.
* Similarly, import() statements inside of classic scripts now use the
  "same-origin" credentials mode, instead of "omit". This affects both
  <script> elements, where the default can be changed using
  crossorigin="", and other contexts like javascript: URLs and classic
  worker scripts, where the default cannot be changed.
* The top-level script for module workers is always fetched with request
  mode "same-origin". Cross-origin workers did not quite work due to
  service workers.

Fixes whatwg#2557. Fixes whatwg#3109.

Tests:

* web-platform-tests/wpt#11274
* web-platform-tests/wpt#13176
* web-platform-tests/wpt#13426
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@annevk @mustaqahmed
Change how module scripts are fetched
f3b33f6 
* Module scripts are always fetched with request credentials mode
  "same-origin" by default, instead of the previous default of "omit".
  Only worker module scripts can still set that to "omit", using the
  credentials option to the Worker constructor. Non-worker module
  scripts, which only have the crossorigin="" attribute available, can
  only toggle between "same-origin" and "include", similar to how
  crossorigin="" works for other platform features.
* Similarly, import() statements inside of classic scripts now use the
  "same-origin" credentials mode, instead of "omit". This affects both
  <script> elements, where the default can be changed using
  crossorigin="", and other contexts like javascript: URLs and classic
  worker scripts, where the default cannot be changed.
* The top-level script for module workers is always fetched with request
  mode "same-origin". Cross-origin workers did not quite work due to
  service workers.

Fixes whatwg#2557. Fixes whatwg#3109.

Tests:

* web-platform-tests/wpt#11274
* web-platform-tests/wpt#13176
* web-platform-tests/wpt#13426
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1502443 [wpt PR 13739] - Change default classic script fetch opti…
f1c6244 
…ons credentials mode, a=testonly

Automatic update from web-platform-testsChange default classic script fetch options credentials mode

This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: web-platform-tests/wpt#13426

R=domenicchromium.org, kouheichromium.org, nhirokichromium.org

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
Reviewed-on: https://chromium-review.googlesource.com/c/1301964
Commit-Queue: Dominic Farolino <domfarolinogmail.com>
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Reviewed-by: Hiroki Nakagawa <nhirokichromium.org>
Cr-Commit-Position: refs/heads/master{#604862}

--

wpt-commits: 085c8a8f6eab33c6586d4d1f9897b700f41c8f54
wpt-pr: 13739

UltraBlame original commit: 16087e3eb569c701d67e7458fbfd7ada4c318d6b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
@marco-c
Bug 1502443 [wpt PR 13739] - Change default classic script fetch opti…
f783246 
…ons credentials mode, a=testonly

Automatic update from web-platform-testsChange default classic script fetch options credentials mode

This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: web-platform-tests/wpt#13426

R=domenicchromium.org, kouheichromium.org, nhirokichromium.org

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
Reviewed-on: https://chromium-review.googlesource.com/c/1301964
Commit-Queue: Dominic Farolino <domfarolinogmail.com>
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Reviewed-by: Hiroki Nakagawa <nhirokichromium.org>
Cr-Commit-Position: refs/heads/master{#604862}

--

wpt-commits: 085c8a8f6eab33c6586d4d1f9897b700f41c8f54
wpt-pr: 13739

UltraBlame original commit: 16087e3eb569c701d67e7458fbfd7ada4c318d6b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1502443 [wpt PR 13739] - Change default classic script fetch opti…
e743c6f 
…ons credentials mode, a=testonly

Automatic update from web-platform-testsChange default classic script fetch options credentials mode

This CL changes the default classic script fetch options credentials mode
from "omit" to "same-origin", as per the recent spec change [1], and adds
descendant worker credentials tests as a follow-up to said spec change and
[2].

[1]: whatwg/html#3656
[2]: web-platform-tests/wpt#13426

R=domenicchromium.org, kouheichromium.org, nhirokichromium.org

Bug: 849101
Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a
Reviewed-on: https://chromium-review.googlesource.com/c/1301964
Commit-Queue: Dominic Farolino <domfarolinogmail.com>
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Reviewed-by: Hiroki Nakagawa <nhirokichromium.org>
Cr-Commit-Position: refs/heads/master{#604862}

--

wpt-commits: 085c8a8f6eab33c6586d4d1f9897b700f41c8f54
wpt-pr: 13739

UltraBlame original commit: 16087e3eb569c701d67e7458fbfd7ada4c318d6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domfarolino domfarolino

Labels
html type:missing-coverage workers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @domfarolino