Skip to content

Commit

Permalink
Don't run permissions iframe tests concurrently with top-level tests
Browse files Browse the repository at this point in the history
This also marks the test as flaky.

Bug: 1411486
Change-Id: Ife3665e2e7985bf6951e8be8b185eaaeb4a90a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4208689
Reviewed-by: Johann Hofmann <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1103865}
  • Loading branch information
cfredric authored and chromium-wpt-export-bot committed Feb 10, 2023
1 parent 0c713b2 commit f574d4f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions storage-access-api/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function processQueryParams() {

// Create an iframe element, set it up using `setUpFrame`, and optionally fetch
// tests in it. Returns the created frame, after it has loaded.
function CreateFrameHelper(setUpFrame, fetchTests) {
async function CreateFrameHelper(setUpFrame, fetchTests) {
const frame = document.createElement('iframe');
const promise = new Promise((resolve, reject) => {
frame.onload = () => resolve(frame);
Expand All @@ -21,7 +21,7 @@ function CreateFrameHelper(setUpFrame, fetchTests) {
setUpFrame(frame);

if (fetchTests) {
fetch_tests_from_window(frame.contentWindow);
await fetch_tests_from_window(frame.contentWindow);
}
return promise;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@
assert_equals(state, "granted");
}, "Permissions grants are observable across same-origin iframes");

// Finally run the simple tests below in a separate cross-origin iframe.
RunTestsInIFrame('https://{{domains[www]}}:{{ports[https][0]}}/storage-access-api/resources/permissions-iframe.https.html');
promise_test(async (t) => {
// Finally run the simple tests below in a separate cross-origin iframe.
await RunTestsInIFrame('https://{{domains[www]}}:{{ports[https][0]}}/storage-access-api/resources/permissions-iframe.https.html');
}, "IFrame tests");
return;
}

Expand Down

0 comments on commit f574d4f

Please sign in to comment.