Skip to content

Commit

Permalink
document.all is not a willful violation of JS
Browse files Browse the repository at this point in the history
  • Loading branch information
annevk authored and sideshowbarker committed Mar 20, 2020
1 parent 2783cec commit c97faeb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions resources/idlharness.js
Original file line number Diff line number Diff line change
Expand Up @@ -2749,7 +2749,7 @@ IdlInterface.prototype.test_object = function(desc)
var expected_typeof;
if (this.name == "HTMLAllCollection")
{
// Willful violation of JS. :(
// Result of [[IsHTMLDDA]] slot
expected_typeof = "undefined";
} else if (this.members.some(function(member) { return member.legacycaller; }))
{
Expand Down Expand Up @@ -2922,7 +2922,7 @@ IdlInterface.prototype.test_interface_of = function(desc, obj, exception, expect
{
if (this.name == "Document" && member.name == "all")
{
// Willful violation of JS :(
// Result of [[IsHTMLDDA]] slot
assert_equals(typeof property, "undefined");
}
else
Expand Down
2 changes: 1 addition & 1 deletion resources/testharness.js
Original file line number Diff line number Diff line change
Expand Up @@ -1484,7 +1484,7 @@ policies and contribution forms [3].
return function (object, property_name, description)
{
assert(typeof object === "object" || typeof object === "function" ||
// Willful violation of JS. :(
// Or has [[IsHTMLDDA]] slot
String(object) === "[object HTMLAllCollection]",
name, description,
"provided value is not an object");
Expand Down

0 comments on commit c97faeb

Please sign in to comment.