-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix selectmenu's button for writing-mode
Before this patch, the selectmenu's button would not rotate when writing-mode is asking it to, but based on the mockups from this issue we should be rotating the button: openui/open-ui#600 Fixed: 1426702 Bug: 1427573 Change-Id: Ib2b4884efa518d2a445638f99d87be66e87138f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4359392 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1121829}
- Loading branch information
1 parent
10c4049
commit c5c18c8
Showing
3 changed files
with
20 additions
and
0 deletions.
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
html/semantics/forms/the-selectmenu-element/selectmenu-writingmode-lr.tentative.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<!DOCTYPE html> | ||
<link rel=author href="mailto:[email protected]"> | ||
<link rel=help href="https://github.com/openui/open-ui/issues/600"> | ||
<link rel=mismatch href="selectmenu-writingmode-tb-ref.html"> | ||
|
||
<selectmenu style="writing-mode: vertical-lr"> | ||
<option>hello</option> | ||
</selectmenu> |
8 changes: 8 additions & 0 deletions
8
html/semantics/forms/the-selectmenu-element/selectmenu-writingmode-rl.tentative.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<!DOCTYPE html> | ||
<link rel=author href="mailto:[email protected]"> | ||
<link rel=help href="https://github.com/openui/open-ui/issues/600"> | ||
<link rel=mismatch href="selectmenu-writingmode-tb-ref.html"> | ||
|
||
<selectmenu style="writing-mode: vertical-rl"> | ||
<option>hello</option> | ||
</selectmenu> |
4 changes: 4 additions & 0 deletions
4
html/semantics/forms/the-selectmenu-element/selectmenu-writingmode-tb-ref.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<!DOCTYPE html> | ||
<selectmenu style="writing-mode: horizontal-tb"> | ||
<option>hello</option> | ||
</selectmenu> |