[LayoutNG] Update legends from getting painted atomically

Legends were getting painted atomically via NGFieldsetPainter::PaintLegend(). This is not according to the spec: https://html.spec.whatwg.org/#the-fieldset-and-legend-elements. Removing the atomic painting of legends also fixes crashing issues in which floating children of legends were getting painted twice. This change adds several test failures to the TestExpectations file. These failures, however, are temporary and will be fixed in a soon-to-follow CL: https://chromium-review.googlesource.com/c/chromium/src/+/2042146 Bug: 875235 Change-Id: I2b9dbc438ba241bcf72eca316ec65aa2f1edc635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045194 Commit-Queue: Alison Maher <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/master@{#740147}
web-platform-tests · Feb 11, 2020 · 8a34c3b · 8a34c3b
1 parent 9adb08e
commit 8a34c3b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/...ing/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order-ref.html b/...ing/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order-ref.html
@@ -0,0 +1,5 @@
+<!doctype html>
+<title>Reference for fieldset painting order</title>
+
+<p>There should be a green square below, and no red.</p>
+<div style="width:100px; height:100px; background:green;"></div>
diff --git a/...ndering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order.html b/...ndering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order.html
@@ -0,0 +1,13 @@
+<!doctype html>
+<title>Legend painting order</title>
+<link rel=match href=legend-painting-order-ref.html>
+
+<p>There should be a green square below, and no red.</p>
+<div style="float:left; width:0px; height:0px;">
+  <div style="width:100px; height:100px; background:red;"></div>
+</div>
+<fieldset style="margin:0; border:none; padding:0;">
+  <legend style="padding:0;">
+    <div style="float:left; width:100px; height:100px; background:green;"></div>
+  </legend>
+</fieldset>