Skip to content

Commit

Permalink
[css-flexbox] Migrate auto-height-with-flex.html to WPT
Browse files Browse the repository at this point in the history
Relevant links:

- original WK patch and fix: [1] and [2].
- W3 discussion that led to both WK and Blink to diverge
 from the spec temporarily (until it got fixed) and match other
 engine's behaviors (eg, Opera, Firefox): [3]

[1] https://bugs.webkit.org/show_bug.cgi?id=116107
[2] http://trac.webkit.org/changeset/150087
[3] https://lists.w3.org/Archives/Public/www-style/2013May/0350.html

BUG=1063749
[email protected], [email protected]

Change-Id: I3d2a087875402954b5b96ff011208bb869ed3664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115768
Reviewed-by: Robert Ma <[email protected]>
Reviewed-by: David Grogan <[email protected]>
Commit-Queue: Antonio Gomes <[email protected]>
Cr-Commit-Position: refs/heads/master@{#752785}
  • Loading branch information
tonikitoo authored and chromium-wpt-export-bot committed Mar 24, 2020
1 parent e343467 commit 2982ebc
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
9 changes: 9 additions & 0 deletions css/css-flexbox/auto-height-with-flex.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!DOCTYPE html>
<link rel="help" href="https://www.w3.org/TR/css-flexbox-1/#flex-basis-property">
<link rel="match" href="reference/auto-height-with-flex-ref.html">
<meta name="assert" content="This test ensures that a vertical flexbox (with auto height) and a flexitem with flex: 1; will not have 0 set to the flex basis, but to auto instead."/>
<div style="display: flex; flex-direction: column; border: 1px solid purple;">
<div>Header</div>
<div style="flex: 1">Flexible content<br>
</div>
</div>
5 changes: 5 additions & 0 deletions css/css-flexbox/reference/auto-height-with-flex-ref.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<div style="border:1px solid purple;">
<div>Header</div>
<div>Flexible content<br>
</div>
</div>

0 comments on commit 2982ebc

Please sign in to comment.