Skip to content

Commit

Permalink
DOM: Implement async iterable conversion support for Observables
Browse files Browse the repository at this point in the history
This CL implements async iterator support for Observables, and adds tons
of WPTs exercising subtle functionality of iterable and async iterable
Observable conversion semantics. It implements the spec text in
WICG/observable#160, and is a follow-up to
https://crrev.com/c/5840672, which brings async iterable support to core
bindings code.

This CL amounts to a partial implementation of async iterable support;
what's missing and what will be included as a follow-up is:

 1. Support for calling the Async Iterator's `return()` method [1] when
    an Observable — when consuming an async iterable — aborts its
    subscription before iterable exhaustion.
 3. A possible refactor to move some of the logic that handles the
    `ScriptIterator` into `ScriptIterator` itself, per discussion in
    [2].

[1]: https://tc39.es/ecma262/#sec-asynciterator-interface
[2]: https://chromium-review.googlesource.com/c/chromium/src/+/5840672/comment/72df95a9_dd32d801/

[email protected]

Bug: 40282760, 363015168
Change-Id: I5f31f4028613245025de71b8975fc92e9d1def0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5850509
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1356228}
  • Loading branch information
domfarolino authored and chromium-wpt-export-bot committed Sep 17, 2024
1 parent 1468690 commit 269cd4a
Showing 1 changed file with 578 additions and 3 deletions.
Loading

0 comments on commit 269cd4a

Please sign in to comment.