Fix Feature Policy report output

This brings the feature policy report format in line with the spec,
and fixes the tests which were broken by WPT import.

Bug: 907232
Change-Id: If9d9469956221c18a1aa72ee39debb1340efc01f
Reviewed-on: https://chromium-review.googlesource.com/c/1338167
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#610427}

feature-policy/experimental-features/resources/common.js

@@ -70,7 +70,7 @@ window.reporting_observer_instance = new ReportingObserver((reports, observer) =
   if (window.reporting_observer_callback) {
     reports.forEach(window.reporting_observer_callback);
   }
-}, {types: ["feature-policy"]});
+}, {types: ["feature-policy-violation"]});
 window.reporting_observer_instance.observe();
 window.reporting_observer_callback = null;
 
@@ -79,7 +79,7 @@ function wait_for_violation_in_file(feature, file_name) {
   return new Promise( (resolve) => {
     assert_equals(null, window.reporting_observer_callback);
     window.reporting_observer_callback = (report) => {
-        var feature_match = (feature === report.body.feature);
+        var feature_match = (feature === report.body.featureId);
         var file_name_match =
             !file_name ||
             (report.body.sourceFile.indexOf(file_name) !== -1);

feature-policy/reporting/camera-report-only.https.html

@@ -10,15 +10,15 @@
     <script>
 var check_report_format = ([reports, observer]) => {
   let report = reports[0];
-  assert_equals(report.type, "feature-policy");
-  assert_equals(report.body.feature, "camera");
+  assert_equals(report.type, "feature-policy-violation");
+  assert_equals(report.body.featureId, "camera");
   assert_equals(report.body.disposition, "report");
 };
 
 promise_test(async t => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   await test_driver.bless('Activate document for user media');
   await navigator.mediaDevices.getUserMedia({video: true});

feature-policy/reporting/camera-reporting.https.html

@@ -13,7 +13,6 @@
   assert_equals(report.type, "feature-policy-violation");
   assert_equals(report.url, document.location.href);
   assert_equals(report.body.featureId, "camera");
-  assert_equals(report.body.disposition, "enforce");
   assert_equals(report.body.sourceFile, document.location.href);
   assert_equals(typeof report.body.lineNumber, "number");
   assert_equals(typeof report.body.columnNumber, "number");

feature-policy/reporting/document-write-report-only.html

@@ -8,15 +8,15 @@
     <script>
 var check_report_format = ([reports, observer]) => {
   let report = reports[0];
-  assert_equals(report.type, "feature-policy");
-  assert_equals(report.body.feature, "document-write");
+  assert_equals(report.type, "feature-policy-violation");
+  assert_equals(report.body.featureId, "document-write");
   assert_equals(report.body.disposition, "report");
 };
 
 promise_test(async t => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   document.write("This should be written into the document");
   check_report_format(await report);

feature-policy/reporting/document-write-reporting.html

@@ -13,7 +13,6 @@
   assert_equals(report.type, "feature-policy-violation");
   assert_equals(report.url, document.location.href);
   assert_equals(report.body.featureId, "document-write");
-  assert_equals(report.body.disposition, "enforce");
   assert_equals(report.body.sourceFile, document.location.href);
   assert_equals(typeof report.body.lineNumber, "number");
   assert_equals(typeof report.body.columnNumber, "number");

feature-policy/reporting/encrypted-media-report-only.https.html

@@ -8,15 +8,15 @@
     <script>
 var check_report_format = ([reports, observer]) => {
   let report = reports[0];
-  assert_equals(report.type, "feature-policy");
-  assert_equals(report.body.feature, "encrypted-media");
+  assert_equals(report.type, "feature-policy-violation");
+  assert_equals(report.body.featureId, "encrypted-media");
   assert_equals(report.body.disposition, "report");
 };
 
 promise_test(async t => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   await navigator.requestMediaKeySystemAccess("org.w3.clearkey",
       [{

feature-policy/reporting/encrypted-media-reporting.https.html

@@ -8,20 +8,19 @@
     <script>
 var check_report_format = (reports, observer) => {
   let report = reports[0];
-  assert_equals(report.type, "feature-policy");
+  assert_equals(report.type, "feature-policy-violation");
   assert_equals(report.url, document.location.href);
-  assert_equals(report.body.feature, "encrypted-media");
+  assert_equals(report.body.featureId, "encrypted-media");
   assert_equals(report.body.disposition, "enforce");
   assert_equals(report.body.sourceFile, document.location.href);
-  assert_equals(typeof report.body.message, "string");
   assert_equals(typeof report.body.lineNumber, "number");
   assert_equals(typeof report.body.columnNumber, "number");
 };
 
 promise_test(async t => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   await promise_rejects(t, "SecurityError",
     navigator.requestMediaKeySystemAccess("org.w3.clearkey",

feature-policy/reporting/fullscreen-report-only.html

@@ -11,15 +11,15 @@
     <script>
 var check_report_format = ([reports, observer]) => {
   let report = reports[0];
-  assert_equals(report.type, "feature-policy");
-  assert_equals(report.body.feature, "fullscreen");
+  assert_equals(report.type, "feature-policy-violation");
+  assert_equals(report.body.featureId, "fullscreen");
   assert_equals(report.body.disposition, "report");
 };
 
 promise_test(async t => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   await test_driver.bless('Activate document for fullscreen');
   await document.getElementById('fs').requestFullscreen();

feature-policy/reporting/fullscreen-reporting.html

@@ -12,7 +12,6 @@
   assert_equals(report.type, "feature-policy-violation");
   assert_equals(report.url, document.location.href);
   assert_equals(report.body.featureId, "fullscreen");
-  assert_equals(report.body.disposition, "enforce");
   assert_equals(report.body.sourceFile, document.location.href);
   assert_equals(typeof report.body.lineNumber, "number");
   assert_equals(typeof report.body.columnNumber, "number");

feature-policy/reporting/generic-sensor-report-only.https.html

@@ -20,19 +20,18 @@
 
     // Validate that the reported feature is one of the sensor features, and that
     // we have not seen a report for this feature before.
-    assert_true(sensor_features_verified.hasOwnProperty(report.body.feature));
-    assert_false(sensor_features_verified[report.body.feature]);
+    assert_true(sensor_features_verified.hasOwnProperty(report.body.featureId));
+    assert_false(sensor_features_verified[report.body.featureId]);
 
     // Validate the remainder of the report
-    assert_equals(report.type, "feature-policy");
+    assert_equals(report.type, "feature-policy-violation");
     assert_equals(report.url, document.location.href);
-    assert_equals(report.body.disposition, "report");
     assert_equals(report.body.sourceFile, document.location.href);
-    assert_equals(typeof report.body.message, "string");
     assert_equals(typeof report.body.lineNumber, "number");
     assert_equals(typeof report.body.columnNumber, "number");
+    assert_equals(report.body.disposition, "report");
 
-    sensor_features_verified[report.body.feature] = true;
+    sensor_features_verified[report.body.featureId] = true;
   }
 
   // Test is only done when reports for all features have been seen
@@ -45,7 +44,7 @@
 
 async_test(t => {
   new ReportingObserver(t.step_func(check_report_format),
-                        {types: ['feature-policy']}).observe();
+                        {types: ['feature-policy-violation']}).observe();
   new Accelerometer();
   new AmbientLightSensor();
   new Gyroscope();

feature-policy/reporting/generic-sensor-reporting.https.html

@@ -20,19 +20,18 @@
 
     // Validate that the reported feature is one of the sensor features, and that
     // we have not seen a report for this feature before.
-    assert_true(sensor_features_verified.hasOwnProperty(report.body.feature));
-    assert_false(sensor_features_verified[report.body.feature]);
+    assert_true(sensor_features_verified.hasOwnProperty(report.body.featureId));
+    assert_false(sensor_features_verified[report.body.featureId]);
 
     // Validate the remainder of the report
-    assert_equals(report.type, "feature-policy");
+    assert_equals(report.type, "feature-policy-violation");
     assert_equals(report.url, document.location.href);
-    assert_equals(report.body.disposition, "enforce");
     assert_equals(report.body.sourceFile, document.location.href);
-    assert_equals(typeof report.body.message, "string");
     assert_equals(typeof report.body.lineNumber, "number");
     assert_equals(typeof report.body.columnNumber, "number");
+    assert_equals(report.body.disposition, "enforce");
 
-    sensor_features_verified[report.body.feature] = true;
+    sensor_features_verified[report.body.featureId] = true;
   }
 
   // Test is only done when reports for all features have been seen
@@ -45,7 +44,7 @@
 
 async_test(t => {
   new ReportingObserver(t.step_func(check_report_format),
-                        {types: ['feature-policy']}).observe();
+                        {types: ['feature-policy-violation']}).observe();
   assert_throws("SecurityError", () => new Accelerometer(), "Constructing sensors should be blocked by policy");
   assert_throws("SecurityError", () => new AmbientLightSensor(), "Constructing sensors should be blocked by policy");
   assert_throws("SecurityError", () => new Gyroscope(), "Constructing sensors should be blocked by policy");

feature-policy/reporting/geolocation-report-only.https.html

@@ -8,15 +8,15 @@
     <script>
 var check_report_format = ([reports, observer]) => {
   let report = reports[0];
-  assert_equals(report.type, "feature-policy");
-  assert_equals(report.body.feature, "geolocation");
+  assert_equals(report.type, "feature-policy-violation");
+  assert_equals(report.body.featureId, "geolocation");
   assert_equals(report.body.disposition, "report");
 };
 
 promise_test(async t => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   try {
     await new Promise((resolve, reject) => {

feature-policy/reporting/geolocation-reporting.https.html

@@ -13,9 +13,7 @@
   assert_equals(report.type, "feature-policy-violation");
   assert_equals(report.url, document.location.href);
   assert_equals(report.body.featureId, "geolocation");
-  assert_equals(report.body.disposition, "enforce");
   assert_equals(report.body.sourceFile, document.location.href);
-  assert_equals(typeof report.body.message, "string");
   assert_equals(typeof report.body.lineNumber, "number");
   assert_equals(typeof report.body.columnNumber, "number");
   assert_equals(report.body.disposition, "enforce");

feature-policy/reporting/microphone-report-only.https.html

@@ -10,15 +10,15 @@
     <script>
 var check_report_format = ([reports, observer]) => {
   let report = reports[0];
-  assert_equals(report.type, "feature-policy");
-  assert_equals(report.body.feature, "microphone");
+  assert_equals(report.type, "feature-policy-violation");
+  assert_equals(report.body.featureId, "microphone");
   assert_equals(report.body.disposition, "report");
 };
 
 promise_test(async t => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   await test_driver.bless('Activate document for user media');
   await navigator.mediaDevices.getUserMedia({audio: true});

feature-policy/reporting/microphone-reporting.https.html

@@ -13,7 +13,6 @@
   assert_equals(report.type, "feature-policy-violation");
   assert_equals(report.url, document.location.href);
   assert_equals(report.body.featureId, "microphone");
-  assert_equals(report.body.disposition, "enforce");
   assert_equals(report.body.sourceFile, document.location.href);
   assert_equals(typeof report.body.lineNumber, "number");
   assert_equals(typeof report.body.columnNumber, "number");

feature-policy/reporting/midi-report-only.html

@@ -8,15 +8,15 @@
     <script>
 var check_report_format = ([reports, observer]) => {
   let report = reports[0];
-  assert_equals(report.type, "feature-policy");
-  assert_equals(report.body.feature, "midi");
+  assert_equals(report.type, "feature-policy-violation");
+  assert_equals(report.body.featureId, "midi");
   assert_equals(report.body.disposition, "report");
 };
 
 promise_test(async t => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   try {
     await navigator.requestMIDIAccess();

feature-policy/reporting/midi-reporting.html

@@ -11,7 +11,6 @@
   assert_equals(report.type, "feature-policy-violation");
   assert_equals(report.url, document.location.href);
   assert_equals(report.body.featureId, "midi");
-  assert_equals(report.body.disposition, "enforce");
   assert_equals(report.body.sourceFile, document.location.href);
   assert_equals(typeof report.body.lineNumber, "number");
   assert_equals(typeof report.body.columnNumber, "number");

feature-policy/reporting/payment-report-only.https.html

@@ -8,15 +8,15 @@
     <script>
 var check_report_format = ([reports, observer]) => {
   let report = reports[0];
-  assert_equals(report.type, "feature-policy");
-  assert_equals(report.body.feature, "payment");
+  assert_equals(report.type, "feature-policy-violation");
+  assert_equals(report.body.featureId, "payment");
   assert_equals(report.body.disposition, "report");
 };
 
 promise_test(async t => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   try {
     const request = new PaymentRequest(

feature-policy/reporting/payment-reporting.https.html

@@ -13,7 +13,6 @@
   assert_equals(report.type, "feature-policy-violation");
   assert_equals(report.url, document.location.href);
   assert_equals(report.body.featureId, "payment");
-  assert_equals(report.body.disposition, "enforce");
   assert_equals(report.body.sourceFile, document.location.href);
   assert_equals(typeof report.body.lineNumber, "number");
   assert_equals(typeof report.body.columnNumber, "number");

feature-policy/reporting/picture-in-picture-report-only.html

@@ -12,8 +12,8 @@
     <script>
 const check_report_format = ([reports, observer]) => {
   const report = reports[0];
-  assert_equals(report.type, "feature-policy");
-  assert_equals(report.body.feature, "picture-in-picture");
+  assert_equals(report.type, "feature-policy-violation");
+  assert_equals(report.body.featureId, "picture-in-picture");
   assert_equals(report.body.disposition, "report");
 };
 
@@ -28,7 +28,7 @@
 promise_pip_test(async (t) => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   const videoElement = await loadVideo();
   await test_driver.bless('picture-in-picture');

feature-policy/reporting/picture-in-picture-reporting.html

@@ -12,14 +12,13 @@
     <script>
 const check_report_format = (reports, observer) => {
   const report = reports[0];
-  assert_equals(report.type, "feature-policy");
+  assert_equals(report.type, "feature-policy-violation");
   assert_equals(report.url, document.location.href);
-  assert_equals(report.body.feature, "picture-in-picture");
-  assert_equals(report.body.disposition, "enforce");
+  assert_equals(report.body.featureId, "picture-in-picture");
   assert_equals(report.body.sourceFile, document.location.href);
-  assert_equals(typeof report.body.message, "string");
   assert_equals(typeof report.body.lineNumber, "number");
   assert_equals(typeof report.body.columnNumber, "number");
+  assert_equals(report.body.disposition, "enforce");
 };
 
 const loadVideo = () => new Promise(resolve => {
@@ -33,7 +32,7 @@
 promise_pip_test(async (t) => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   const videoElement = await loadVideo();
   await test_driver.bless('picture-in-picture');

feature-policy/reporting/sync-xhr-report-only.html

@@ -8,15 +8,15 @@
     <script>
 const check_report_format = ([reports, observer]) => {
   const report = reports[0];
-  assert_equals(report.type, "feature-policy");
-  assert_equals(report.body.feature, "sync-xhr");
+  assert_equals(report.type, "feature-policy-violation");
+  assert_equals(report.body.featureId, "sync-xhr");
   assert_equals(report.body.disposition, "report");
 };
 
 promise_test(async t => {
   const report = new Promise(resolve => {
     new ReportingObserver((reports, observer) => resolve([reports, observer]),
-                          {types: ['feature-policy']}).observe();
+                          {types: ['feature-policy-violation']}).observe();
   });
   const xhr = new XMLHttpRequest();
   xhr.open("GET", document.location.href, false);

feature-policy/reporting/sync-xhr-reporting.html

@@ -13,7 +13,6 @@
   assert_equals(report.type, "feature-policy-violation");
   assert_equals(report.url, document.location.href);
   assert_equals(report.body.featureId, "sync-xhr");
-  assert_equals(report.body.disposition, "enforce");
   assert_equals(report.body.sourceFile, document.location.href);
   assert_equals(typeof report.body.lineNumber, "number");
   assert_equals(typeof report.body.columnNumber, "number");